feat: show welcome page based on major upgrade status - #337
Open
xionglinlin wants to merge 1 commit into
Open
Conversation
1. Add DConfig option "showWelcomePage" to control welcome page display after updates 2. Allow user to disable welcome page entirely via configuration 3. For minor updates (non-major upgrades), skip welcome page and directly enter desktop 4. Parse "MajorUpgrade" option from lastore-daemon to determine upgrade type 5. Add ShowWelcomePage DConfig JSON configuration file with default true 6. Install the new DConfig file to proper system directory 7. Add majorUpgrade state tracking in UpdateModel 8. Log skip behavior for debugging purposes Log: 更新完成后根据升级类型和配置控制欢迎界面显示 Influence: 1. Verify welcome page shows after major version upgrades when config is enabled 2. Verify welcome page is skipped after minor version updates 3. Test with showWelcomePage set to false to ensure welcome page never shows 4. Test with showWelcomePage set to true to confirm default behavior 5. Verify MajorUpgrade option parsed correctly from lastore-daemon 6. Test config file installation and DConfig service pickup 7. Confirm logs correctly record why welcome page was skipped feat: 根据大版本升级状态显示欢迎界面 1. 添加 DConfig 配置项 "showWelcomePage" 用于控制更新后的欢迎界面显示 2. 允许用户通过配置完全关闭欢迎界面 3. 小版本更新(非大版本)跳过欢迎界面,直接进入桌面 4. 从 lastore-daemon 解析 "MajorUpgrade" 选项以确定升级类型 5. 添加 ShowWelcomePage DConfig JSON 配置文件,默认值为 true 6. 将新的 DConfig 文件安装到系统目录 7. 在 UpdateModel 中添加 majorUpgrade 状态跟踪 8. 记录跳过行为日志以便调试 Log: 更新完成后根据升级类型和配置控制欢迎界面显示 Influence: 1. 验证大版本升级后配置开启时显示欢迎界面 2. 验证小版本更新后跳过欢迎界面 3. 测试将 showWelcomePage 设为 false 时任何更新都不显示欢迎界面 4. 测试 showWelcomePage 设为 true 时保持默认行为 5. 验证从 lastore-daemon 正确解析 MajorUpgrade 选项 6. 测试配置文件安装及 DConfig 服务加载 7. 确认日志正确记录跳过欢迎界面的原因 PMS: TASK-394209 Change-Id: I5cf78da22c11a9847a1881e1bdf5021f078e79a6
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xionglinlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThe update flow now shows the welcome page only for major upgrades when the new showWelcomePage DConfig option is enabled; minor upgrades and disabled configuration exit directly to the desktop, while MajorUpgrade is parsed from lastore-daemon and tracked in UpdateModel. Sequence diagram for conditional welcome page display after updatessequenceDiagram
participant Lastore as lastore-daemon
participant Worker as UpdateWorker
participant Model as UpdateModel
participant Check as CheckSystemWidget
participant Config as DConfig
participant Desktop as Desktop
Lastore->>Worker: getUpdateOption()
Worker->>Worker: parse MajorUpgrade
Worker->>Model: setMajorUpgrade(majorUpgrade)
Check->>Config: getConfig(showWelcomePage)
Check->>Model: majorUpgrade()
alt showWelcomePage is true and majorUpgrade is true
Check->>Check: create SuccessFrame
else configuration disabled or minor upgrade
Check->>Check: qApp->exit()
Check->>Desktop: enter desktop
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: 更新完成后根据升级类型和配置控制欢迎界面显示
Influence:
feat: 根据大版本升级状态显示欢迎界面
Log: 更新完成后根据升级类型和配置控制欢迎界面显示
Influence:
PMS: TASK-394209
Change-Id: I5cf78da22c11a9847a1881e1bdf5021f078e79a6
Summary by Sourcery
Control post-update welcome page display based on the upgrade type and user configuration.
New Features:
Enhancements:
Build: