fix(build): add missing sources and includes to qmake pri files - #355
Merged
deepin-bot[bot] merged 1 commit intoSep 1, 2026
Merged
Conversation
New eyeprotection module and RestoreTipWidget were added to CMakeLists but missing from qmake pri files, causing build and link failure. Also add XpsTextExtractor to the xps_support conditional block. 新增护眼模块与RestoreTipWidget时只更新了CMakeLists.txt， qmake工程缺失对应源文件与头文件搜索路径，导致编译链接失败。 同时补全xps_support条件编译块中遗漏的XpsTextExtractor。 Log: 修复qmake工程缺失新模块文件导致的构建失败 Influence: qmake构建恢复正常，可正确编译护眼模块、RestoreTipWidget 及XPS文本提取器。
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFixes qmake builds by synchronizing manually maintained pri files with the newly added eye-protection, RestoreTipWidget, and XPS text-extractor files; no runtime logic changes are introduced. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
📝 代码变更概要本次 PR 修复 qmake 构建配置缺失问题，共修改 4 个 .pri 文件（新增 15 行，删除 0 行）：
🔍 详细分析1. 语法逻辑 ✅评分： 25/25 ✓ 通过 评价词： 语法正确，逻辑清晰 潜在问题： 分析说明：
2. 代码质量 ✅评分： 24/25 ✓ 通过 评价词： 代码结构清晰 潜在问题：
建议：
分析说明：
3. 代码性能 ✅评分： 20/20 ✓ 通过 评价词： 性能良好，资源使用合理 潜在问题： 分析说明：
4. 代码安全 🔒评分： 30/30 ✓ 通过 存在0个安全漏洞 漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个 安全漏洞详情： 安全扫描工具结果说明： 安全扫描器报告了 3 个"高危路径遍历"告警，经 AI 审计全部判定为误报：
OCR 审查结果： 0 条评论，"Looks good to me." 分析说明：
💡 改进建议# reader/eyeprotection/eyeprotection.pri
# Eye Protection module - sources and headers
HEADERS += \
$$PWD/EyeProtectionManager.h \
$$PWD/EyeProtectionAction.h
SOURCES += \
$$PWD/EyeProtectionManager.cpp \
$$PWD/EyeProtectionAction.cpp
INCLUDEPATH += $$PWD📋 审查清单
本报告由 AI 代码审查工具自动生成 |
lzwind
approved these changes
Sep 1, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
新增的护眼模块（eyeprotection）和 RestoreTipWidget 只更新了 CMakeLists.txt，qmake 工程文件（.pri）缺失对应源文件与头文件搜索路径，导致 qmake 构建失败：
fatal error: EyeProtectionManager.h: No such file or directoryundefined reference to RestoreTipWidget::*修改内容
已对全部 7 个模块目录与 pri 列表做全量比对，无其他遗漏。
自测
deb-builder-launcher.sh ll构建通过（4分2秒），产物 layer 导出成功。【版本号】：deepin-reader > 6.5.60
【自测环境镜像版本】：V25
【代码地址】：本 PR
【根因分析】：新增文件只更新了 CMake 通配符自动收录的 CMakeLists.txt，漏改了 qmake 手写显式列表的 .pri 文件
【影响范围】：仅影响 qmake 构建，不改变代码逻辑
【自测结果截图/视频】：通过，见备注
【自测架构】: x86
Summary by Sourcery
Update qmake project files so all required reader modules, headers, and sources are included during builds.
Bug Fixes:
Build: