Skip to content

fix(a11y): add AT-SPI names for exposure slider and image menu - #523

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
re2zero:fix/at-spi-completion-20260828
Aug 28, 2026
Merged

fix(a11y): add AT-SPI names for exposure slider and image menu#523
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
re2zero:fix/at-spi-completion-20260828

Conversation

@re2zero

@re2zero re2zero commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

AT-SPI 补全 — deepin-camera

补全内容

为以下 2 个交互控件补全 setObjectName() / setAccessibleName()

文件 控件 类型 名称
src/src/exposureslider.cpp m_slider DSlider Slider
src/src/imageitem.cpp m_menu QMenu Menu

覆盖率对比

阶段 覆盖率 ok gap
补全前 92.0% 23 2
补全后 100.0% 25 0

验证

  • quality_gate.py 重新扫描通过(100% 覆盖,0 new gap)
  • 本地编译通过(cmake build)
  • 不含无关文件改动(仅 2 个 .cpp,+4 行)

分支

fix/at-spi-completion-20260828

Summary by Sourcery

Complete AT-SPI naming for the exposure slider and image menu to achieve full accessibility coverage.

Bug Fixes:

  • Add accessible object and accessible names for the exposure slider and image context menu to close AT-SPI accessibility gaps.

Chores:

  • Update the image item copyright year range.

@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sourcery-ai

sourcery-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Completes accessibility naming for the exposure slider and image context menu by setting both Qt object names and accessible names, bringing the reported AT-SPI coverage from 92% to 100%; also updates the image item copyright year range.

File-Level Changes

Change Details Files
Adds AT-SPI-identifiable object and accessible names to the exposure slider and image context menu.
  • Names the vertical exposure slider for accessibility-tree discovery.
  • Names the image item context menu for assistive technologies.
  • Preserves existing control initialization and action setup order.
src/src/exposureslider.cpp
src/src/imageitem.cpp
Updates the image item copyright range.
  • Extends the copyright year range through 2026.
src/src/imageitem.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Add setObjectName/setAccessibleName for m_slider in ExposureSlider
and m_menu in ImageItem so accessibility tools can locate them.

为 ExposureSlider 的 m_slider 和 ImageItem 的 m_menu 补全
setObjectName/setAccessibleName,使无障碍工具可定位控件。

Log: 补全相机AT-SPI控件名称
Influence: 补全2个交互控件的无障碍名称,AT-SPI覆盖率从92%提升至100%。
@re2zero
re2zero force-pushed the fix/at-spi-completion-20260828 branch from fdcc21f to 7547610 Compare August 28, 2026 06:41
@re2zero
re2zero marked this pull request as ready for review August 28, 2026 08:29

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交为2个UI控件补全AT-SPI无障碍名称,代码变更精准、范围清晰,无安全漏洞,无语法逻辑、代码质量或性能问题。变更完全符合PR描述的无障碍覆盖率提升目标。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例

// 暂无代码示例

本报告由 AI 代码审查工具自动生成

@re2zero

re2zero commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot
deepin-bot Bot merged commit 80a5c00 into linuxdeepin:master Aug 28, 2026
17 checks passed
@re2zero
re2zero deleted the fix/at-spi-completion-20260828 branch August 28, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants