feat: add AT-SPI accessibility support for all interactive widgets - #607
feat: add AT-SPI accessibility support for all interactive widgets#607MyLeeJiEun wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @MyLeeJiEun, your pull request is larger than the review limit of 150,000 diff characters
|
I have read the CLA Document and I hereby sign the CLA. |
b383a28 to
3ddfac4
Compare
Add accessible names and roles to interactive widgets across the codebase to enable screen reader compatibility and accessibility testing. C++ changes (25 widgets named in 13 files): - DViewItemAction items: setObjectName() only (QAction has no setAccessibleName) - QWidget items: both setObjectName() and setAccessibleName() QML changes (178 elements named in 26 files): - Standard types: Accessible.name only - Custom types: Accessible.name + Accessible.role Coverage improvement: - C++: 28.2% -> 92.3% - QML: 0.0% -> 100.0% Issue: DDE-164
3ddfac4 to
1f397a3
Compare
2 participants
Summary
Add AT-SPI accessibility support to all interactive widgets in dde-network-core.
Changes
C++ (25 widgets named, 13 files modified)
setObjectName()onlysetObjectName()+setAccessibleName()QML (178 elements named, 26 files modified)
Accessible.nameAccessible.name+Accessible.roleCoverage Improvement
The 3 remaining C++ gaps are false positives:
m_connectionAction: declared but never instantiated (nullptr)m_parentWidget: parent reference (not owned by this class)m_view: const pointer (not owned)Test Artifacts
Scan results and name mappings are included in
tests/at/spi/:pre_scan_gaps.yaml/pre_scan_ok.yaml: C++ scan resultsqml_gaps.yaml/qml_ok.yaml: QML scan resultsexpected_names.yaml: Expected accessible names for automated testingname_map.txt: Variable-to-name mappingsTesting
Quality gate passed:
Closes #DDE-164