fix: disable x11 bypass flag in launcher windowed mode - #798
Closed
wjyrich wants to merge 1 commit into
Closed
Conversation
1. Set `useX11BypassWindowManagerHint` to `false` in the windowed mode launcher PanelPopup 2. This ensures the launcher window respects window manager positioning and stacking rules on systems that may have issues with the bypass hint Log: Fixed launcher windowed mode positioning on X11 systems Influence: 1. Verify the windowed mode launcher still opens correctly 2. Test that the launcher window is properly positioned and can be managed by the window manager 3. Verify launcher visibility toggling still works in windowed mode fix: 在启动器窗口模式中禁用x11绕过标志 1. 将窗口模式启动器的 `PanelPopup` 中的 `useX11BypassWindowManagerHint` 设置为 `false` 2. 确保启动器窗口在具有绕过提示问题的系统上遵守窗口管理器的定位和堆叠 规则 Log: 修复 X11 系统上启动器窗口模式的定位问题 Influence: 1. 验证窗口模式启动器仍能正常打开 2. 测试启动器窗口能被正确定位并可被窗口管理器管理 3. 验证窗口模式下启动器的可见性切换功能仍然正常 PMS: TASK-394541
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adjusts the windowed-mode launcher popup’s X11 window manager behavior by disabling the bypass hint, ensuring it obeys normal positioning/stacking rules, and includes a minor Debian packaging control file change. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review★ 总体评分：95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/shell-launcher-applet/package/launcheritem.qml b/shell-launcher-applet/package/launcheritem.qml
index b14ba723..69456f1c 100644
--- a/shell-launcher-applet/package/launcheritem.qml
+++ b/shell-launcher-applet/package/launcheritem.qml
@@ -265,6 +265,8 @@ AppletItem {
PanelPopup {
id: windowedModeLauncher
+ // 显式关闭绕过窗口管理器，修复X11下窗口行为异常
+ useX11BypassWindowManagerHint: false
property bool visibility: LauncherController.visible && (LauncherController.currentFrame === "WindowedFrame") |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider whether other
PanelPopupusages in the launcher or shell should also haveuseX11BypassWindowManagerHintexplicitly set for consistent window manager behavior across modes. - If this change is intended to affect only X11, you may want to guard it with platform checks or confirm that forcing
useX11BypassWindowManagerHint: falsedoes not introduce regressions on Wayland or non-X11 environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider whether other `PanelPopup` usages in the launcher or shell should also have `useX11BypassWindowManagerHint` explicitly set for consistent window manager behavior across modes.
- If this change is intended to affect only X11, you may want to guard it with platform checks or confirm that forcing `useX11BypassWindowManagerHint: false` does not introduce regressions on Wayland or non-X11 environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useX11BypassWindowManagerHinttofalsein the windowed mode launcher PanelPopupLog: Fixed launcher windowed mode positioning on X11 systems
Influence:
fix: 在启动器窗口模式中禁用x11绕过标志
PanelPopup中的useX11BypassWindowManagerHint设置为falseLog: 修复 X11 系统上启动器窗口模式的定位问题
Influence:
PMS: TASK-394541
Summary by Sourcery
Bug Fixes: