Repository navigation
client: Match items without xdg:schema against Generic schema queries - #641
Merged
Merged
Conversation
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
Items migrated from old gnome-keyring may lack the xdg:schema attribute. When a client like gcr's SSH agent searches with xdg:schema set to org.freedesktop.Secret.Generic (via libsecret's SECRET_SCHEMA_NONE), treat schema-less items as implicitly generic so they still match. Closes: #586
bilelmoussaoui
force-pushed
the
bilelmoussaoui-potential-fix
branch
from
November 8, 2026 12:38
71e5602 to
cc37507
Compare
gnome-keyring exposes a schema derived from the item type for items without an xdg:schema attribute. Keep it when migrating so schema based lookups still match them.
Items lacking xdg:schema match Generic schema searches, but not when creating an item with replace, so gcr ended up storing duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items migrated from old gnome-keyring may lack the xdg:schema attribute.
When a client like gcr's SSH agent searches with xdg:schema set to
org.freedesktop.Secret.Generic (via libsecret's SECRET_SCHEMA_NONE),
treat schema-less items as implicitly generic so they still match.