Repository navigation
Conversation
The field was filled from WebAuthn's user.displayName while the neighbouring name field holds user.name, so "username" pointed at the wrong value. Use the WebAuthn name instead and document both fields. This changes the dict key sent with SelectingCredential, so it is listed as a breaking change of the UI Controller API. Refs linux-credentials#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credential.usernamewas filled from WebAuthn'suser.displayName, whilenameholdsuser.name, so the field name pointed at the wrong value. This renames it todisplay_nameto match WebAuthn and documents both fields.Credential.username->display_namedisplay_namein the USB and NFC credential listsCredentialObjectproperty; the label text is unchanged (name (display name))SelectingCredentialchangesTests: a check that
Credentialserializes with thename/display_namedict keys, and round-trip tests for the GTKCredentialObject(the property name is only checked at runtime).meson test5/5.This issue was claimed in Aug 2025 with no PR since; I asked on the issue first. Happy to close this if that work is still going on.
Closes #79