Repository navigation
fix: actually handle NonTerminatingCancellation error - #249
Merged
iinuwa merged 1 commit intoNov 2, 2026
Merged
Conversation
michaelbeaumont
marked this pull request as ready for review
November 2, 2026 21:01
iinuwa
requested changes
Nov 2, 2026
iinuwa
left a comment
iinuwa
left a comment
Member
There was a problem hiding this comment.
Nice catch!
Left a nit to fix. Also, could you change the commit message to daemon: Fix hybrid cancellation handling and add a CHANGELOG entry?
michaelbeaumont
force-pushed
the
fix/non-terminating-cancel
branch
from
November 2, 2026 22:02
8e0a2c4 to
fb2402e
Compare
We get `false` from `is_ceremony_terminating` so that branch was never taken.
michaelbeaumont
force-pushed
the
fix/non-terminating-cancel
branch
from
November 2, 2026 22:04
fb2402e to
e6fd116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get
falsefromis_ceremony_terminatingso that branch was never taken.Atm I'm getting: