Skip to content

Document platform details for FMA - #438

Merged
Shnatsel merged 4 commits into
linebender:mainfrom
RunDevelopment:fma-platform-details
Nov 6, 2026
Merged

Shnatsel merged 4 commits into
linebender:mainfrom
RunDevelopment:fma-platform-details

Conversation

@RunDevelopment

Copy link
Copy Markdown
Contributor

Small PR to document which platforms return results with one rounding error for SimdFloat::{mul_add,mul_sub}.

I also changed the parameter names to a and b to match the standard library.

@Shnatsel

Shnatsel commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

I think "one or two rounding errors" would be more clear.

But I'm not convinced we should document the list of platforms explicitly; if someone needs single-rounding FMA they should use mul_add_precise, not look at the list of platforms and go "well this is all I support so it's fine". Make a portable choice either for guaranteed precision or guaranteed performance.

@Shnatsel

Shnatsel commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

I think a similar note on performance on mul_add_precise describing where it is or isn't a single native instruction is a better idea.

Admittedly it's the same info, just framed differently.

@RunDevelopment

RunDevelopment commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

No, I like the idea of framing it as a perf note. Will do.

@Shnatsel
Shnatsel added this pull request to the merge queue Nov 6, 2026
Merged via the queue into linebender:main with commit 0ad315e Nov 6, 2026
23 checks passed
@RunDevelopment
RunDevelopment deleted the fma-platform-details branch November 6, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants