Repository navigation
Add signed/unsigned casting - #435
Open
RunDevelopment wants to merge 1 commit into
Open
RunDevelopment wants to merge 1 commit into
RunDevelopment wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
SimdInt::{Signed, Unsigned, cast_signed, cast_unsigned}to allow users to cast the signedness of a vector without needing to name the target vector type. Similar to #420.I also added
SimdInt::unsigned_abs()because it's trivial to implement using the new APIs.I'm thinking of this PR as prep for
abs_diff, but I'm not sure if this is the right approach long term. IMO,std::simd's traitsSimdIntandSimdUintare much more elegant, but it's a little late for that now. Except if we add traits liketrait SimdSigned: SimdIntandtrait SimdUnsigned: SimdIntand move all sign-specific operations there.Ideas very welcome.