Repository navigation
hy-check/walk: collect calls and fnlits across nested assign target places (Fixes #3762) - #3763
Merged
limitlessprojects merged 1 commit intoNov 6, 2026
Conversation
Burapa-J
force-pushed
the
fix/walk-assign-target-place-calls-and-fnlits
branch
from
November 6, 2026 06:01
5ecb5c0 to
956fe0a
Compare
Owner
|
Landed — thank you @Burapa-J. What landed (fixes #3762 —
Verification evidence (full battery on the merged trial tree):
Bounty rail: per BOUNTY.md / discussion #295. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3762
Cause
own_calls(compiler/crates/hy-check/src/walk.rs:545-549) only matched top-levelPlaceKind::Index, skipping calls insidePlaceKind::Field(arr[mutate(m)].val = 99),PlaceKind::AddrOf, and nestedPlaceKind::Index(mat[mutate(m)][0] = 99) targets.own_fnlits(compiler/crates/hy-check/src/walk.rs:618-622) only traversedvaluesonStmt::Assign, skippingExpr::FnLitclosures inside assignment target index expressions.Fix
place_callsandplace_fnlitshelpers incompiler/crates/hy-check/src/walk.rsmirroringplace_uses.place_callsinown_callsandplace_fnlitsinown_fnlitsfor allStmt::Assigntargets.compiler/crates/hy-check/tests/walk_assign_target_place_calls.rs.Verification
cargo test -p hy-check --test walk_assign_target_place_calls(4 passed)cargo test -p hy-check --lib(183 passed)