fix(grid-wallet-prod): npm ci --ignore-scripts so the image can build#746
Open
mariano-macri wants to merge 1 commit into
Conversation
The Dockerfile added in #740 has never produced an image. `npm ci` dies in the deps stage: the seven @central-icons-react packages each run a postinstall license-check.js that hard-fails unless CENTRAL_LICENSE_KEY is in the environment, and that variable appears nowhere in this repo. npm error path /app/node_modules/@central-icons-react/round-filled-radius-2-stroke-2 npm error command sh -c node ./license-check.js npm error Error: Central Icons license key is not set. vercel.json for this same component already sets `installCommand: npm install --ignore-scripts`, which is why the Vercel deployments work and the container build never did. This aligns the Dockerfile with the install behavior the component is actually developed and shipped against. No dependency here needs a postinstall to produce a working build. Verified linux/arm64 end to end: image builds (332MB), /app/server.js is the entrypoint, NEXT_PUBLIC_GRID_SANDBOX inlines into the client bundle, the server boots and serves / with 200 carrying no Grid credentials, and an unsigned POST /api/webhooks is rejected 401 by the signature check. Co-Authored-By: Claude Opus 5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile SummaryAligns the container dependency installation with the component’s existing Vercel installation behavior.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| components/grid-wallet-prod/Dockerfile | Updates the dependency stage to install packages without lifecycle scripts, matching the component’s Vercel configuration. |
Reviews (2): Last reviewed commit: "fix(grid-wallet-prod): npm ci --ignore-s..." | Re-trigger Greptile
Author
|
@greptileai review No new commits since your last review — re-triggering for a fresh pass alongside the rest of the stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile added in #740 has never produced an image
npm cidies in the deps stage. The seven@central-icons-reactpackages each run a postinstalllicense-check.jsthat hard-fails unlessCENTRAL_LICENSE_KEYis set, and that variable appears nowhere in this repo:#740 noted the build as unverified ("the daemon wasn't running here"). It's not merely unverified — it cannot succeed as written.
Why
--ignore-scriptsis the right fix herecomponents/grid-wallet-prod/vercel.jsonalready sets:{ "installCommand": "npm install --ignore-scripts" }That's why the Vercel deployments of this component work and the container build never did. This aligns the Dockerfile with the install behavior the component is actually developed and shipped against. No dependency here needs a postinstall to produce a working build.
Verified end to end (linux/arm64)
/app/server.jsis the entrypoint (flat, not nested — this component has its own lockfile and the repo root has noworkspaces)NEXT_PUBLIC_GRID_SANDBOXinlines into the client bundle/with 200 carrying no Grid credentialsPOST /api/webhooksis rejected 401 by the signature checkScope
Dockerfile only. Splitting this out from the CI-workflow PR that stacks on top of it, since this is a bug fix you want whether or not the tooling-cluster deployment ever happens.
🤖 Generated with Claude Code