Skip to content

chore: Sync account schemas#738

Open
lightspark-copybara[bot] wants to merge 1 commit into
mainfrom
auto/sync-grid-schemas-20260724-001130
Open

chore: Sync account schemas#738
lightspark-copybara[bot] wants to merge 1 commit into
mainfrom
auto/sync-grid-schemas-20260724-001130

Conversation

@lightspark-copybara

Copy link
Copy Markdown
Contributor

Auto-synced account schemas.

These schemas are generated from VASP adapter field definitions in sparkcore.

Synced schemas:

  • common/ — per-currency account info, beneficiary, and payment account schemas
  • common/PaymentInstructions.yaml — payment instructions oneOf (new currencies added)
  • external_accounts/ — per-currency external account schemas (reference common/)

Please review the changes before merging.

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Preview Jul 24, 2026 12:11am
grid-wallet-demo Ignored Ignored Preview Jul 24, 2026 12:11am

Request Review

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

go

feat(api): add rail parameter to PHP external account creation

kotlin

feat(api): add rail field to PhpExternalAccountCreateInfo and PhpAccountInfo

openapi

feat(api): add rail field to PHP account model

php

feat(api): add rail field to PhpExternalAccountCreateInfo and PhpAccountInfo

python

feat(api): add rail field to PhpExternalAccountCreateInfo

ruby

feat(api): add rail parameter to PHP account models

typescript

feat(api): add rail field to PHP external account types

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-typescript studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ✅

npm install https://pkg.stainless.com/s/grid-typescript/8666456d8218dc8d711cad4001247b70f251447d/dist.tar.gz
grid-openapi studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️

grid-ruby studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

grid-go studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@5b793c2c76bdcc648d067f73bd64d1768cf8d87a
grid-kotlin studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ✅lint ✅test ❗

grid-python studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

pip install https://pkg.stainless.com/s/grid-python/3536c13ba575c723fe51d1bce939203b801add4d/grid-0.0.1-py3-none-any.whl
grid-php studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅lint ✅test ✅

grid-cli studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ❗lint ❗test ❗


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-24 00:16:40 UTC

@mintlify

mintlify Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟡 Building Jul 24, 2026, 12:11 AM

@mintlify

mintlify Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Jul 24, 2026, 12:13 AM

@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This auto-synced PR adds a rail field to the PHP (Philippine Peso) account schema and updates the bankName description in the GTQ (Guatemalan Quetzal) schema. Both openapi.yaml and mintlify/openapi.yaml are generated bundles that reflect the same changes.

  • PHP rail field added — a new optional string field (1–32 chars) to specify the payment rail for routing payouts, but its description and example mistakenly reference Indian rails (NEFT/RTGS for INR) rather than Philippine rails (PESONet/InstaPay).
  • GTQ bankName description updated — wording simplified from "The name of the beneficiary's bank" to "The name of the bank"; no functional change.
  • Generated bundles updatedopenapi.yaml and mintlify/openapi.yaml are kept in sync with the source schema changes.

Confidence Score: 3/5

The GTQ change is safe, but the PHP rail field ships with a description and example drawn from Indian payment infrastructure (NEFT/RTGS) rather than Philippine ones — this would actively mislead API consumers integrating against a PHP account endpoint.

The rail field's description and example both point API consumers toward the wrong payment system. Any developer reading the schema to decide what value to send for a Philippine Peso payout will see NEFT as the example and Indian rails in the description, and is likely to submit an invalid or wrong rail identifier. The field itself and its constraints look correct; only the documentation is wrong, but in an OpenAPI spec the documentation is the contract.

openapi/components/schemas/common/PhpAccountInfoBase.yaml — the rail field description and example need to reference Philippine payment rails (PESONet, InstaPay) instead of Indian ones (NEFT, RTGS for INR).

Important Files Changed

Filename Overview
openapi/components/schemas/common/PhpAccountInfoBase.yaml Adds a new optional rail field to the PHP account schema, but its description and example reference Indian payment rails (NEFT/RTGS for INR) rather than Philippine rails (PESONet/InstaPay).
openapi/components/schemas/common/GtqAccountInfoBase.yaml Minor description wording change for bankName from "The name of the beneficiary's bank" to "The name of the bank" — no functional impact.
openapi.yaml Generated bundle reflecting the same PHP rail field addition and GTQ description tweak; inherits the INR-reference issue from the source schema.
mintlify/openapi.yaml Mintlify-specific generated bundle with identical changes; same issue propagated here.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PHP Payout Request] --> B{rail field provided?}
    B -- yes --> C[Route via specified rail\ne.g. PESONet / InstaPay]
    B -- no --> D[Default routing]
    C --> E[PHP Payout Executed]
    D --> E
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
openapi/components/schemas/common/PhpAccountInfoBase.yaml:11-17
**INR rail references inside a PHP schema**

The new `rail` field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets `rail: NEFT` — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.

Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile

Comment on lines +11 to +17
rail:
type: string
description: The payment rail to route the payout over, for currencies that support
more than one (e.g. NEFT or RTGS for INR).
example: NEFT
minLength: 1
maxLength: 32

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 INR rail references inside a PHP schema

The new rail field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets rail: NEFT — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfoBase.yaml
Line: 11-17

Comment:
**INR rail references inside a PHP schema**

The new `rail` field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets `rail: NEFT` — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants