chore: Sync account schemas#738
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-go studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-python studio · code · diff
✅ grid-php studio · code · diff
✅ grid-cli studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Greptile SummaryThis auto-synced PR adds a
Confidence Score: 3/5The GTQ change is safe, but the PHP The openapi/components/schemas/common/PhpAccountInfoBase.yaml — the
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/PhpAccountInfoBase.yaml | Adds a new optional rail field to the PHP account schema, but its description and example reference Indian payment rails (NEFT/RTGS for INR) rather than Philippine rails (PESONet/InstaPay). |
| openapi/components/schemas/common/GtqAccountInfoBase.yaml | Minor description wording change for bankName from "The name of the beneficiary's bank" to "The name of the bank" — no functional impact. |
| openapi.yaml | Generated bundle reflecting the same PHP rail field addition and GTQ description tweak; inherits the INR-reference issue from the source schema. |
| mintlify/openapi.yaml | Mintlify-specific generated bundle with identical changes; same issue propagated here. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PHP Payout Request] --> B{rail field provided?}
B -- yes --> C[Route via specified rail\ne.g. PESONet / InstaPay]
B -- no --> D[Default routing]
C --> E[PHP Payout Executed]
D --> E
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
openapi/components/schemas/common/PhpAccountInfoBase.yaml:11-17
**INR rail references inside a PHP schema**
The new `rail` field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets `rail: NEFT` — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.
Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
| rail: | ||
| type: string | ||
| description: The payment rail to route the payout over, for currencies that support | ||
| more than one (e.g. NEFT or RTGS for INR). | ||
| example: NEFT | ||
| minLength: 1 | ||
| maxLength: 32 |
There was a problem hiding this comment.
INR rail references inside a PHP schema
The new rail field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets rail: NEFT — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfoBase.yaml
Line: 11-17
Comment:
**INR rail references inside a PHP schema**
The new `rail` field's description and example both reference Indian payment infrastructure (NEFT/RTGS for INR) inside a Philippine Peso (PHP) account schema. The description reads "e.g. NEFT or RTGS for INR" and the example sets `rail: NEFT` — NEFT is the National Electronic Funds Transfer system used in India, not the Philippines. For PHP accounts the relevant rails would be PESONet or InstaPay. Any consumer reading this schema to understand what values to send will be misled into submitting an Indian rail identifier for a Philippine account.
How can I resolve this? If you propose a fix, please make it concise.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.