Add missing libewf_extent_get_values() to support multi-extent files (and minor fix for MSVSCPP project) - #218
Add missing libewf_extent_get_values() to support multi-extent files (and minor fix for MSVSCPP project)#218datasynergyuk wants to merge 2 commits into
Conversation
…se\bzip2.lib'" in MSVSCPP build. Fix is to add 'libbz2.def' module defintion (.def) file so that the MSVSCPP project will emit required LIB file. Also modified project output filename to match bzip2/libbzip2 default of "LIBBZ2.dll". This is a partial fix for the DLL name issue. The full fix would be to rename the project "LIBBZ2", however, this may have other implications so I have not touched this.
… This will allow existing code to stop using deprecated methods get_media_data_offset()/get_media_data_size(). An extra bonus is that data_flags comes back per-extent , so per-extent sparse detection now becomes possible.
|
Thanks for the proposed changes. I'll take a closer look when time permits. Note that I'll not merge the changes to the visual studio files. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 39.47% 39.81% +0.33%
==========================================
Files 101 101
Lines 41381 40928 -453
Branches 9538 9543 +5
==========================================
- Hits 16335 16294 -41
+ Misses 21595 21203 -392
+ Partials 3451 3431 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you. Please can I ask why you will not merge the changes to the visual studio files? Is this because you think they are wrong, you can't test them or because you are not worried about Visual Studio compatibility? It would be helpful to know for future PR's. For what it is worth, it is a simple fix required due to recent changes in BZip2 |
|
They are autogenerated with https://github.com/libyal/vstools from the autoconf/make files. Also note that bzip2 support is early WIP |
|
Ok. Thank you for explaining. I will look into vstools and see if my fix is applicable there. |
Add missing libewf_extent_get_values() to support multi-extent files. This will allow existing code to stop using deprecated methods: get_media_data_offset()/get_media_data_size(). An extra bonus is that data_flags comes back per-extent, so per-extent sparse detection now becomes possible
Also fixed "LINK : fatal error LNK1181: cannot open input file '..\release\bzip2.lib'" in MSVSCPP build. Fix is to add 'libbz2.def' module defintion (.def) file so that the MSVSCPP project will emit required LIB file. Also modified project output filename to match bzip2/libbzip2 default of "LIBBZ2.dll". This is a partial fix for just the DLL name issue. The full fix would be to rename the project "LIBBZ2", however, this may have other implications so I have not touched this.