Repository navigation
Conversation
Caprica derives a script's expected namespace from its path relative to the input directory. The rule passed the temp directory above `Scripts`, so every Fallout 4 script failed with "expected namespace 'Scripts:...'". Pass `Scripts` itself and write to `<targetdir>/Scripts`, which keeps the output layout the archive and install hooks rely on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonlib.papyrushands Caprica the temp directory aboveScriptsas its input. Caprica derives a script's expected namespace from its path relative to the input directory, so with--game=fallout4a namespaced script fails:With
--game=skyrimthe same input compiles, and there the extra level is what puts the output underScripts/.This passes
rootdir(theScriptsdirectory) as the input instead, and writes to<targetdir>/Scripts, so the output keeps theScripts/...layout that thearchiveandinstallhooks pick up throughscriptdir/(**).Tested with Caprica v0.3.0 (the latest release), xmake 3.0.9, Windows 11:
commonlibf4.papyrusin a project (imports given explicitly,skip_default_imports = true): before this change, the error above; after it,build/papyrus/Scripts/FO4A/Proef.pex.Scripts/ProefSky.pex. Compared field by field, the pex is identical apart from the compilation time in the header, which also differs between two runs of the current rule.The
archiveandinstallhooks were not exercised; their paths are unchanged by construction.Based on
29fbdb0.Disclosure: I am a blind developer and I prepared this with AI assistance.