Repository navigation
wayland: Handle drop event data reads asynchronously - #16532
Merged
Merged
Conversation
slouken
approved these changes
Oct 15, 2026
Kontrabant
marked this pull request as draft
October 16, 2026 16:45
Contributor
Author
|
Hmm, there is a rare case where this could still block and/or deadlock due to queues holding the global Wayland display lock when dispatching. Need to rework this. |
Kontrabant
force-pushed
the
wl_async_cb
branch
from
October 16, 2026 18:42
f4374cf to
cb10bd3
Compare
Kontrabant
marked this pull request as ready for review
October 18, 2026 15:57
Kontrabant
force-pushed
the
wl_async_cb
branch
10 times, most recently
from
October 19, 2026 23:55
4c7e8fd to
fb228f6
Compare
Previously, drop events had a hard timeout value of 14ms to prevent blocking the main event loop for too long while reading remote data. This timeout could be too short in some cases, leading to failed drop events, so the timeout has been increased, and drop events read the remote data asynchronously to prevent blocking the main event loop for excessive periods.
Kontrabant
force-pushed
the
wl_async_cb
branch
from
October 20, 2026 15:14
fb228f6 to
cf9cce1
Compare
Contributor
Author
|
Ok, reworked, tested, re-tested, and finally ready to go. No blocking under normal operation, and no deadlocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, drop events had a hard timeout value of 14ms to prevent blocking the main event loop for too long while reading remote data. This timeout could be too short in some cases, leading to failed drop events, so the timeout has been increased, and drop events read the remote data asynchronously to prevent blocking the main event loop for excessive periods.
Fixes #16521
Closes #16406