Repository navigation
Suppress deprecation warnings found while creating swift package (PR 1/3) - #16300
jasonbobier wants to merge 5 commits into
Conversation
|
@icculus, do we actually want to silence these deprecation warnings? |
|
I would argue that you do because they are noise that hide actual warnings. These aren't real warnings because you are supporting OS versions that require the code that cause the warnings. Hiding each individually means that it is easy to search for them later whenever you update your minimum OS requirements. And a warning free build should always be the end goal imo. |
|
Yeah, I'm pretty sure these are all fallbacks where we have a more modern approach in place for newer systems. Gonna go over all of these though, to make sure we can't just delete a few of them. What is the minimum macOS at this point? |
https://github.com/libsdl-org/SDL/blob/main/docs/README-macos.md That's probably going to bump up soon though. Xcode 27 doesn't support targeting less than macOS 12.0 (and iOS/tvOS 15.0) and is annoyingly strict about this. |
|
I believe that the minimum for the swift package work that I'm doing is macOS 13. That still supports almost 10 year old machines and most folks that I know that run those old machines convert them to some brand of Unix because apple stops doing security updates. :-/ |
…ation suppressions.
|
Since this hasn't been merged yet, I went ahead and merged other deprecation warning removals into this PR. |
jasonbobier
changed the title
…n-warnings # Conflicts: # src/notification/cocoa/SDL_cocoanotification.m
Note that the code is written (well copied and pasted all over :)) by me, but the comments are a mix of my comments and what Claude told me to make sure that I was giving accurate notes.
Description
Wrapped the deprecation warnings in:
clang diagnostic ignored "-Wdeprecated-declarations"Also added swiftpm related directories to the .gitignore in preparation for another PR.
Additional:
Modernizes code for maximum texture size on visionOS.
Existing Issue(s)