Fix SMART temperature parsing in smart-v1 - #635
Merged
Conversation
Fix "drive_drip" typo: should be "drive_trip"
Fix max_temp selection logic in the three cases selecting the maximum temperature from SMART attributes 190 and 194. The defined() calls incorrectly contain && expressions. The && expression is evaluated first and its result is passed to defined(), rather than testing whether the individual value is defined and numeric. The conditions are corrected so that the presence and numeric validity of SMART attributes 190 and 194 are tested independently. No other SMART parsing logic is changed.
|
|
Collaborator
|
derp, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in
snmp/smart-v1related to SMART temperature handling:Fix
drive_driptypo: should bedrive_trip.Fix
max_tempselection logic in the three cases selecting the maximum temperature from SMART attributes 190 and 194.The
defined()calls incorrectly contain&&expressions. The&&expression is evaluated first and its result is passed todefined(), rather than testing whether the individual value is defined and numeric.The conditions are corrected so that the presence and numeric validity of SMART attributes 190 and 194 are tested independently.
No other SMART parsing logic is changed.