You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
gossipsub: Re-write tests to remove technical debt #3371
With #3327, we took out some technical debt to move forward with #2824. The tests which currently depend on ConnectionId should be refactored to spin up a Swarm and establish an actual connection which will then allow us to remove ConnectionId::DUMMY.
Activity
thomaseizinger commentedon Jan 24, 2023
dgarus commentedon Mar 12, 2023
@thomaseizinger
Hello, Thomas!
I tried to find a comment with the issue number, but couldn't.
Is something changed?
I would like to try to make this issue.
Thanks!
thomaseizinger commentedon Mar 12, 2023
Thanks for wanting to tackle this!
You can also search for all usages of
ConnectionId::DUMMY, that should you lead to the same code places that need fixing!thomaseizinger commentedon Mar 21, 2023
Usages of
ConnectionId::DUMMYare being replaced in #3652. We still want to rewrite those tests to createSwarms instead though.