Repository navigation
Concurrent dials to the same peer with duplicated multiaddrs #3209
Description
Summary
Useless concurrent dials when a peer is found with two identical multiaddrs in the DHT: one with a peerid, and the other without a peerid.
Expected behaviour
When dialing a peer, identical multiaddrs (that only differ with the presence of the peerid) should be filtered out in order to prevent useless concurrent dials to the same peer.
Actual behaviour
Two identical mutliaddrs filled by the DHT:
/ip4/10.10.0.1/tcp/80
and
/ip4/10.10.0.1/tcp/80/QmXXXXXXXX
are concurrently dialed twice.
Possible Solution
Maybe check uniqueness of multiaddrs without peerid
Version
- libp2p version (version number, commit, or branch): 0.49
Would you like to work on fixing this bug?
No
Activity
thomaseizinger commentedon Dec 8, 2022
Thanks for the report! I agree that it makes sense to do some better filtering here.
thomaseizinger commentedon Dec 22, 2022
Needs a test before we can consider this closed.
thomaseizinger commentedon Sep 20, 2023
@stormshield-pj50 Does this still occur?
stormshield-pj50 commentedon Sep 20, 2023
Not any more, that's fixed. You can close the issue.