Repository navigation
Offer to install Windows App Runtime from the Microsoft Store - #4
Merged
Merged
Conversation
The release executables imported VCRUNTIME140.dll, so on Windows without the Visual C++ Redistributable, such as a fresh LTSC or Sandbox image, the loader refused to start the tool before its Windows App Runtime check could run.
A missing runtime used to leave users with a download link and an installer to run by hand. The Store install service accepts requests from unpackaged processes and installs the framework package by product ID even though its Store page offers no way to acquire it, so the prompt now installs it in place with a progress dialog and continues once the required version is present. Detection and installation come from nyanpasu-windows-dependencies, which also decides whether the Store is usable: without the Store app, as on LTSC, the install service still answers but finds no product, and only the download choices are offered. The support crates it uses are patched to the vendored windows-rs so the executable keeps one copy of windows-core.
|
Review changes with Changed Files
|
Clash Nyanpasu switched to the segment heap and freed about 6 MiB of private memory that the NT heap had been keeping after frees. The tool's WinUI process allocates the same way, so it uses the same manifest setting.
greenhat616
marked this pull request as ready for review
October 21, 2026 06:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
9NRZT3Q9R3DLthrough the Store install service with a progress dialog, re-checks the version and continues startup. Failures fall back to the existing download choices.VCRUNTIME140.dll, so on Windows without the VC++ Redistributable (fresh LTSC / Sandbox) the tool could not start at all.heapTypeelement is in the embedded manifest and the executable still starts in Windows Sandbox.Verification
cargo clippy --all-targets -- -D warnings,cargo test(52 passed).zprofile without build-std): 1,425,920 → 1,478,144 bytes for the Store feature, → 1,575,424 with the static CRT.Not yet verified