Repository navigation
Conversation
|
it is just preparation for better ci process in repo @wilsonwang371 and we use coderrabbit for our repos, good reviewer for first step. maybe you can integrate it too |
|
The reason for not running on pull requests is that currently I am paying out of my own pockets for all the tests that triggers OpenAI API calls. If we do this on each of the pull request, I think I can run out of tokens very soon. |
|
fair point. pushed new one |
let me take a look at the MR tomorrow. |
|
@moezdil I think you many need to take a look at all the issues before making a new patch |
yeah i look at it |
|
i v run again in my nvidia card, lts see |
|
@moezdil does it make sense to skip the checks even if it failed? |
|
you're right, they can't fail right now so they don't check anything. main has 45 fmt diffs in 20 files (#100), lots of clippy warnings and 28 audit advisories, so i can't make them blocking yet. i'll take them out of this pr, so everything left (build, tests, frontend) really blocks. we can add them back once main is clean. |
|
If all these clippy or other lint warning need to be resolved, I suggest making patch to fix each type of the warnings and then add these checks in the CI yaml |
|
sounds good, will do. fmt first (#100), then clippy one warning type per pr, and each check goes back into ci.yml once main is clean. |
Add a CI workflow that runs on pull requests and pushes to main: cargo check --all-features --all-targets, make test, frontend lint/build/test for web-admin and web-console, and a ci-ok job to use as the single required check. fmt, clippy and cargo audit run but are not blocking yet. Add dependabot for cargo, npm and github-actions. Signed-off-by: mesutoezdil <[email protected]>
Live OpenAI tests skip without a key, so PR runs no longer need the secrets. Signed-off-by: mesutoezdil <[email protected]>
Pass -include cstdint for librocksdb-sys and install web-admin deps, which web-console imports from. Signed-off-by: mesutoezdil <[email protected]>
The vec is pushed to under the sled and rocksdb features, so --all-features failed to compile. Signed-off-by: mesutoezdil <[email protected]>
Import the factory types in kv-examples, bind db_path in kv_factory_usage, and make the edge case test configs mutable. Signed-off-by: mesutoezdil <[email protected]>
Signed-off-by: mesutoezdil <[email protected]>
Signed-off-by: mesutoezdil <[email protected]>
Signed-off-by: mesutoezdil <[email protected]>
e2678f2 to
8080f47
Compare
Right now CI only runs on
push, so PRs get no checks (see #98). This adds aci.ymlthat runs on pull requests and on pushes to main.rust:cargo fmt --check,cargo check --all-features --all-targetsandmake test, no OpenAI secrets needed (live tests skip).frontend: lint, build and test forweb-adminandweb-console.ci-ok: one job to mark as required in branch protection.dependabot.ymlfor cargo, npm and github-actions.clippy and audit are left out until main is clean. Also fixes three compile errors in tests and examples that
--all-featurescaught. Part of #99 and #101.