Skip to content

fix(core): P2 fail-closed root conditional exports — original source red first - #21

Merged
AlexanderLevenskikh merged 3 commits into
mainfrom
fix/p2-conditional-exports-root-20261122
Nov 22, 2026
Merged

AlexanderLevenskikh merged 3 commits into
mainfrom
fix/p2-conditional-exports-root-20261122

Conversation

@AlexanderLevenskikh

Copy link
Copy Markdown
Contributor

Source-backed false positive boundary, separate from P6/P7 holdouts

Base accepted P2 main 88066bc119fa5bad4601d27433ff813151443bbe. Two previously studied frozen public package manifests: TanStack Form 5de1a8de01e3d63a0e5225a7e659a384f3a0effb and React Hook Form 8d7bd6c2c774fd9b4310e8cbc07d36ce1cacf736. Their public exports['.'] targets are dist-only. Source snapshot may contain a nearby src/index.ts, but no evidence establishes dist→src mapping. Current fallback can incorrectly create certainty:'verified' edge.

First SHA tests-only, includes two source-backed negatives, blocked conditional import, type-only runtime block and exact-source/legacy positive controls. Preserve real red GitHub CI before modifying resolver. Correct only empirically failing tests; don't inspect/modify untouched P7. Require full eight-platform CI/byte parity, original nine TypeChecker/Knip, exact PR+merge SHA. No release, publish, tag, credential or toolchain changes.

…nned packages

Source-backed TanStack Form and React Hook Form published dist-only exports must not silently become verified src/index.ts edges; explicit blocked import and type-only cases stay unknown. Preserve source-exact positive cases. Test-only RED before any resolver changes.
Preserve original four red source-backed regressions plus positive/negative controls. Explicit export roots and subpaths are authoritative; no dist-to-src fallback, blocked import/null stays UNKNOWN, type-only not runtime. Bump graph cache version; no holdout or release edits.
…rce main

Include original P6 98 unmodified labels from main, preserving P7 pristine freeze separate. Keep original conditional exports RED tests and scoped fix, rerun all eight CI cells with byte parity and 12-source independent evaluation before merge.
@AlexanderLevenskikh
AlexanderLevenskikh marked this pull request as ready for review November 22, 2026 14:48
@AlexanderLevenskikh
AlexanderLevenskikh merged commit 9b6761e into main Nov 22, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant