Repository navigation
Fix native Codex handoffs with shared daemon writer ownership - #34
Open
penguinboi wants to merge 2 commits into
Open
penguinboi wants to merge 2 commits into
penguinboi wants to merge 2 commits into
Conversation
Use thread/read directly during post-launch capture and reconciliation. Retain terminal-turn, workspace, and session identity checks before import. Add real installed-Codex regressions for reader and canonical capture paths.
Connect native interactive preparation and projection to the running Codex daemon so detached threads retain one writer. Validate its socket and version, and close only the bridge connection on shutdown. Keep standalone control connections process-owned. Check sync response errors in the native smoke and accept Claude screen-reader trust prompts. Real native-owner probes and a three-turn conversational round trip verify capture and context recall in both directions.
penguinboi
force-pushed
the
fix/codex-native-writer
branch
from
September 30, 2026 23:10
61ac25b to
f5491ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Codex detach leaves the shared daemon owning the mapped thread. Agentctl previously resumed it through a separate app-server during capture and later projection, causing an active-writer error and blocking return to Claude.
Read persisted history without resuming it. For native interactive preparation and projection on Unix, connect to the running native daemon through its WebSocket control socket, validate the endpoint and CLI/daemon versions, and close only the bridge connection during shutdown. Standalone adapters retain their owned stdio server.
The native smoke now checks provider errors in both sync responses and handles Claude screen-reader trust prompts. The thread-continuity guard is unchanged; sibling attribution remains tracked in #32.
Validation: real regressions failed before and passed after the fix; all five Codex live probes and the CLI capture probe passed. A native Claude → Codex → Claude smoke and a three-model-turn conversational round trip passed with recall in both directions, canonical capture, stable native mappings, and two immediate error-free syncs. Workspace tests, clippy with warnings denied, formatting, docs, shell syntax/ShellCheck, audit, and dependency policy checks passed. Dependency policy checks report duplicate crate-version warnings. Live validation used macOS arm64, Codex0.159.2 and Claude2.1.286; Windows shared-daemon support was not added.
Fixes #33.