Repository navigation
Conversation
#1047) The runtime splits Metal graphs through upstream's eval callback, so the GPU watchdog no longer trips on a full-VAE decode. The core lifts its iOS full-VAE refusal when sd_dart_graph_split_threshold exists and returns above 0; a runtime without it keeps the refusal.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.3.0-4(prerelease; native commit4a84ac24, manifest SHA-25686c67491…33a1) and regenerates the bindings (sd_dart_graph_split_set_threshold,sd_dart_graph_split_threshold,sd_dart_graph_split_cuts).ImageGenerationEngine.loadno longer refuses a full VAE whensd_dart_graph_split_thresholdexists and returns above 0 (StableDiffusionCalls.graphSplit,StableDiffusionRuntimeStatus.splitsGraphsOnMetal). A runtime without it keeps the refusal and the intrinsic-tiny route; its message namesv0.3.0-4. ThevaeDirectConvolution: truerefusal (#1044) is unchanged.Production-readiness scope
v0.3.0-4runtime (the pin). Other platforms unchanged.LlamaUnsupportedException(iOS Metal full VAE) as before. Known limit: on iOS 26 the second engine dispose can leave about 2 GB resident, so later loads may fail the memory check (#2004); documented, not fixed here.llamadart_stable_diffusion_flutteris re-released at release prep: its## Unreleasedsection (Package.swift pin and checksum already synced) becomes the next version, floorstableDiffusionAppleCompanionVersion = '0.19.10'.stableDiffusionCompatibleAppleCompanionTagsis empty (the sync clears it), so no older Apple SD companion is admitted; release prep must either qualifyv0.3.0-3with a compatibility fixture or accept the exclusion (verify_release_docs_versions.dartalready reports the pending bump). Final public-API DDP qualification at the PR head is pending (separate run).Completeness checklist
capability_coverage.jsonreason for the iOS Metal VAE restriction);validation_coverage_test.dartpasses.PR type guidance
lib/src); docs, support matrix, skill, changelog updated; tests cover the split-runtime load, the old-runtime refusal, the probe, and the retained vaeDirectConvolution: true returns corrupt images on iPhone Metal #1044 refusal.Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzeTMPDIR="$(mktemp -d)" dart test -p vm -j 1 --exclude-tags local-only(14497 passed)dart test -p chrome --exclude-tags local-only(4914 passed)coverage-lib: 93.93% line coveragedart test -p vm test/unit/tooling/(includingvalidation_coverage_test.dartandpackage_skills_test.dart),check_platform_boundaries.dart,python3 tool/native/test_sync_stable_diffusion_bindings.py,python3 tool/native/test_sync_native_release_pins.py,./tool/docs/build_site.shdart test -p vm --run-skipped -t local-only test/integration/stable_diffusion_runtime_hook_test.dart(macOS)splitsGraphsOnMetalcheck to false fails the split-runtime load test; forcing the probe'ssplitsGraphsOnMetalto false fails the probe test.Matrix Evidence
coverage-liblib/coverageimage-generation-smokeLLAMADART_SD_TURBO_MODEL)run_local_e2e.dartimage-exit-teardownrun_local_e2e.dart0d022638…)llamadart-evidence/issue-1047/0.19.10/results/ddp-c1/results/ddp-c2b/Review Notes
3109f05df.High-risk regression review
artifactConsumer,backendRuntime)3109f05df/cde82afb0requiresIosTinyDecodernow also needs!runtime.splitsGraphsOnMetal; the flag comes only from the runtime probe (sd_dart_graph_split_threshold> 0). Tests cover both paths; mutating the flag fails them.