Repository navigation
Repin WebGPU bridge assets to v0.1.85 with isolation and GPU fallback errors (#1025) - #2001
Merged
Merged
Conversation
…llback reasons (#1025) Map the bridge's CrossOriginIsolationError to LlamaUnsupportedException on direct and worker loads, name the gpu_unavailable reason in the ComputeDevice.gpu error, drop the stale threads_capped_no_coi hint, and document the measured Safari 27, Firefox 160 and NVIDIA L4 results.
Contributor
|
Chat app preview removed for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.1.85(immutable, bridgef1ac2fc1, nativev0.9.0), for #1025 in the 0.19.10 plan.CrossOriginIsolationError(CROSS_ORIGIN_ISOLATION_REQUIRED) toLlamaUnsupportedExceptionnaming COOP/COEPrequire-corp(and thatcredentiallessdoes not isolate Safari), on the direct and worker paths.gpu_unavailable:<reason>note to the "loaded the model without GPU layers" error (adapter_missing_shader_f16namesshader-f16and NVIDIA driver 615.71+); older assets keep the current text.threads_capped_no_coichat-app hint and fixtures (the typed load error now carries the isolation message); document the measured Safari 27, Firefox 160 and NVIDIA L4 results.Production-readiness scope
ComputeDevice.gpufailures say why WebGPU was not used.LlamaUnsupportedException; assets older thanv0.1.85emit nogpu_unavailablenote and keep the plain GPU error.webgpu_load_retry_policy.dartstill treatsthreads_capped_no_coias a thread failure (and its tests keep that note) for older assets.Completeness checklist
validation_coverage_test.dartpasses).PR type guidance
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm -j 1 --exclude-tags local-only(14432 pass)dart test -p chrome --exclude-tags local-only(all pass)coverage-libmatrix row: PASS: 93.93% line coverage (34422/36645). One unrelated two-process download test failed once under coverage (child could not resolve its cache dir) and passes alonedart test -p vm test/unit/tooling/,check_webgpu_bridge_tag.dart --verify-manifest, chat appflutter test test test_vmand the Chrome list,./tool/docs/build_site.shMatrix Evidence
coverage-libweb-lazy-grammarweb-production-artifact-smoke--coep require-corp, real worker/GGUFv0.1.85web-chrome-runtime-smokedart test -p chromeMutations (each killed by the new tests): dropped GPU reason text, isolation mapping disabled,
codecheck removed,namecheck removed, driver-version text changed, unknown-reason text removed.Review Notes
18918034no-block; delta re-audit at7801bdf3no-block (fresh agents, not the author).7801bdf3f78c70eb46dc230c794783f1a1c51061(33 pass, 9 skipped).High-risk regression review
llamadart-evidence/pr-2001/andpr-2001/delta-7801bdf3/(readiness evaluator exit 2)7801bdf3/1ce4565ccheck_webgpu_bridge_tag.dart --verify-manifest)nvidia-fallback/gce/gce-run2/), not re-run hereRemaining P3s (tracked on #1993): v0.1.85 rows sit above v0.1.84 in two version lists; the v0.1.85 rows say a page without cross-origin isolation is rejected at once, but the check is whether shared memory is usable (flag-enabled non-isolated Chrome still loads);
allowSingleThreadCoreis not reachable from llamadart.