Skip to content

Refuse unparseable and uppercase-scheme model URLs in the JSON Schema device e2e - #1921

Merged
leehack merged 1 commit into
mainfrom
lane-1861-b3
Nov 11, 2026
Merged

leehack merged 1 commit into
mainfrom
lane-1861-b3

Conversation

@leehack

@leehack leehack commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Summary

Production-readiness scope

  • User-facing scope: None (maintainer e2e tooling).
  • Supported platforms/paths: tool/testing only.
  • Unsupported or intentionally unavailable paths: None changed.
  • Out of scope / follow-ups: Remaining 0.19.x audit follow-ups (index) #1861 items are tracked there.

Completeness checklist

  • Declared scope is fully implemented.
  • Unsupported platform/option combinations: unchanged.
  • Changelog entries updated where user-visible (N/A for tooling-only).
  • Regression coverage covers the original finding and fails first against origin/main.
  • Validation coverage registry: N/A, no capability change.
  • No secrets or signed URLs leak through logs or errors.
  • Follow-ups: None beyond 0.19.x audit follow-ups (index) #1861.

PR type guidance

  • Bugfix PR: root cause and regression test are in the summary.

Test Plan

  • dart run tool/prepare_workspace.dart
  • dart format --output=none --set-exit-if-changed .
  • dart analyze
  • dart test -p vm test/unit/tooling/: only the six windows_registry_qualification_test.dart cases fail locally (no pwsh)

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
validation-harness tool/testing macOS VM PASS

Review Notes

  • Independent review status: N/A (not yet requested)
  • CI status / head SHA: pending

High-risk regression review

  • Classification: standard
  • Implementation task: N/A
  • Independent blocking QA task: N/A
  • Exact head / current base: N/A
  • Production-branch deletion, bypass, or miswire proof: N/A
  • Affected-family real-model/artifact evidence: N/A
  • Explicit unavailable-family or other N/A evidence: N/A
  • Known PR-caused P1 regressions: 0
  • Unresolved review threads: 0

@leehack
leehack marked this pull request as ready for review November 11, 2026 09:38
@leehack
leehack merged commit 7b08e9f into main Nov 11, 2026
43 checks passed
@leehack
leehack deleted the lane-1861-b3 branch November 11, 2026 09:38
@github-actions

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1921.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant