Repository navigation
Conversation
This was referenced Nov 11, 2026
14 of 16 tasks
Owner
Author
Contributor
|
Chat app preview removed for |
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-at-value-endcopy name that no converter rule holds, so a nested property namedat-value-endno longer defines a rule twice and rejects valid calls (0.19.x audit follow-ups (index) #1861, Parse Qwen3-Coder XML call bodies as llama.cpp does (#1898) #1906 re-audit).</seed:tool_call>no longer ends the returned content; the calls are kept (0.19.x audit follow-ups (index) #1861, Parse Seed-OSS tool calls closer to llama.cpp (#1898) #1908 re-audit).The grammar change only renames rules; llama.cpp errors on the Seed-OSS input, so there is no new oracle row.
Production-readiness scope
Completeness checklist
origin/main.PR type guidance
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzexml_argument_grammar_test,seed_oss_handler_test(each new test fails againstorigin/maincode)run_template_parity_suites.sh,coverage-lib: results in a PR commentMatrix Evidence
structured-output-adversarialroot-vmroot-chromeReview Notes
High-risk regression review