Repository navigation
Drop the unused LiteRT-LM Metal accelerator from Apple bundles - #1913
Merged
Merged
Conversation
v0.19 Apple LiteRtLm links its GPU accelerator statically (Metal on iOS, WebGPU on macOS), so LiteRT never opens the separate Metal accelerator. Pin litert-lm-native v0.19.1-3, which stops shipping it, and teach the pin sync script the v0.19 Metal transition. Refs #1798
Its Android arm64 archive is byte-identical to v0.19.1-2.
This was referenced Nov 10, 2026
leehack
marked this pull request as ready for review
November 10, 2026 23:05
…-metal-accelerator
Contributor
|
Chat app preview removed for |
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ed8ffe33), which no longer ships the unused LiteRT Metal accelerator on iOS and macOS.LiteRtLmlinks its GPU accelerator statically (iOS Metal, macOS WebGPU). LiteRT'sgpu_registrysearches shared libraries only when no static one registered, soLiteRtMetalAcceleratorwas never opened.LiteRtMetalAcceleratortarget from the Apple companionPackage.swiftand its entries from the hook pins, macOS runtime inventory and prepare script;sync_native_release_pins.pylearns the v0.19 Metal transition (kept while every iOS bundle ships it, removed once none does, refused if only some do).v0.19.1-3in the LiteRT-LM library smoke and the S24 binding: its Android arm64 archive is byte-identical tov0.19.1-2(all files, SHA-256 compared).litert_lm/<ver>/macos/arm64libLiteRtMetalAccelerator.dylibLiteRtMetalAccelerator.frameworkLiteRtMetalAcceleratorxcframework zipProduction-readiness scope
LLAMADART_LITERT_LM_LIB_DIRruntimes older than v0.19.1-3 still load; the Metal accelerator is no longer required from them.Completeness checklist
validation_coverage_test.dartpasses).PR type guidance
tool/native/test_sync_native_release_pins.py). Affected platforms: iOS and macOS.Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm -j 1 --exclude-tags local-only(only the 6 Windows registry tests fail locally:pwshis not installed here)dart test -p chrome --exclude-tags local-onlycoverage-lib: 93.67% linescheck_native_release_digests.dart(8 LiteRT-LM bundles match v0.19.1-3),verify_release_docs_versions.dart(reports the expected pending companion bump),(cd packages/llamadart_litert_lm_flutter && flutter test), owner CI run 42858395264 and release run 42879370634Matrix Evidence
native-sync-python-suitescoverage-liblitert-lm-chat-features-smoke.litertlmchat, tool loop, thinking--backend gpu, hook cache v0.19.1-3GPU WebGPUstatically; no Metal file in the hook cachemacos-arm64-runtime-smokelitert_lm_chat_smoke.py --backend gpuios-simulator-smokeGPU Metalregistered, Metal device created, reply "42"; evidence inllamadart-evidence/litert-lm-native-118/ios-arm64-device-smokerelease-companion-pub-gateverify_release_docs_versions.dartreports the pending bump for release prepReview Notes
6a0d0f9a(fresh auditor session, 0 P1/P2). The audit also checked a merge with current main2cfb9361: it merges cleanly, analyze is clean, and 2711 targeted tests pass. Evidence:llamadart-evidence/pr-1913/; evaluator exit 2.752b027fbb1d5b4481f78084901ca484a4f08513, a merge of main2cfb9361into the audited6a0d0f9a. The merge was needed because GitHub ignores the changelogs' union merge driver. The delta re-audit passed: only the union-merged changelogs differ, all mutants were re-run, and the evaluator exits 2.High-risk regression review
artifactConsumer,backendRuntime)6a0d0f9a, 0 P1/P2. Maintainer merge approval given ("Merge Drop the unused LiteRT-LM Metal accelerator from Apple bundles #1913").6a0d0f9a1a1539a1f65a50b1078d80c490c21403/33e00f5a7a.litertlmon macOS GPU and the iOS simulator against the owner candidate and published v0.19.1-3 inventory; Metal absence verified in the published tarballs