Repository navigation
Batch integration for 0.19.5: #1901 #1902 #1906 #1908 #1910 #1907 #1909 - #1912
Merged
Merged
Conversation
leehack
marked this pull request as ready for review
November 10, 2026 22:05
This was referenced Nov 10, 2026
Closed
Contributor
|
Chat app preview removed for |
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch integration PR for 0.19.5 (plan #1899), per
doc/high_risk_pre_merge_readiness.md"Batch integration PR". Seven constituents, one commit each, cut frommainat33e00f5a7. #1798 is not included and lands on its own later. Do not squash-merge: rebase merge only.Closes #1905. The other constituents carry no closing keyword (#1901, #1902 and #1907/#1909 use
Refs); they are tracker items under #1861, #1898 and #174, which are not closed by this PR.Constituents (commit order)
All are high-risk per
classify_high_risk_changes.dart; each head below is the head that was audited. Evidence:/opt/UnitySrc/personal/llama/llamadart-evidence/pr-N/.getContextSizereports the enforced limitbackendRuntime)d2f58aaa5d8602bedfe3f66156954853aaf1bd00d739cfdb8pr-1901/pub_content_limitscomment-onlyreleaseAutomation, comment-only)d4fa3267a3d13bafc42a3d18a22ac5889a30704ed739cfdb8pr-1902/structuredOutput)61a3140d0ee37846d0dd775a621a408c5f8b64ea33e00f5a7pr-1906/structuredOutput)6e241a3617521805d000b33859740da3cb94bf7d61a3140d0(#1906 head)pr-1908/structuredOutput)99b9c89605808400e955de3ef4113cf52fb0360f33e00f5a7pr-1910/backendRuntime,regressionPolicy,structuredOutput)18e3993fc84fdbe7a99f9e7e8d0f66330428d3ff33e00f5a718e3993f(0 P1/P2); waiver belowpr-1907/backendRuntime,regressionPolicy,structuredOutput)bc5d97267c628aa0832c40c3657d207d31f49da918e3993fc(#1907 head)pr-1909/The constituent PR bodies still say "audit pending" for some rows; the integration audit and this table are the record for the batch.
Maintainer waiver (#1907)
One-time waiver (2026-11-10) of the
compiled_grammar_acceptanceandcompiled_grammar_rejectionaxes, conditional on the audit confirming #1907 compiles no grammar; the re-audit at18e3993fconfirmed it. The evaluator has no waiver flag, so it exits 1 (missingStructuredOutputEvidence) on exactly those two axes; all other axes are met. Details in the #1907 PR body.Conflict resolutions
None. Every constituent diff applied onto the integration tree with
git apply --3wayand no conflicts, including the shared docs (template-engine-internals.md, both changelogs, support matrix, README, skills).Verification that the tree is the union of the audited diffs: for each commit, the added/removed lines of
git diff -U0 <base> <pinned head>equal those of the commit, except one added blank line after## Unreleasedin each changelog (it is added once by the first constituent that fills the section, so later PRs' own blank line is not repeated). Changelogs: each of the 6 bullets (#1901, #1906, #1908, #1910, #1907, #1909; #1902 has none) is exactly once under## UnreleasedinCHANGELOG.mdandwebsite/docs/changelog/recent-releases.md; released sections untouched.Commit subjects are the PR titles with
(#N)appended where the title did not already end in it; the body is(#N, audited head <sha>).Production-readiness scope
responseFormatwidened per Widen native LiteRT-LM JSON Schema to Gemma 4, macOS GPU and the shared schema contract #1907/Gate native LiteRT-LM JSON Schema per qualified host and accelerator #1909; Web LiteRT-LM context size; template parsers for Qwen3-Coder, Nemotron, StepFun, Seed-OSS and MiniMax M3.LlamaUnsupportedException.Completeness checklist
validation_coverage_test.dartpasses in the VM suite.PR type guidance
Test Plan
Local, on the combined tree at
a9c777252, Flutter 3.47.1:dart run tool/prepare_workspace.dart(clean tree after)dart format --output=none --set-exit-if-changed .dart analyze: no issuesdart run tool/testing/check_platform_boundaries.dartdart test -p vm -j 1 --exclude-tags local-only --coverage=coverage: 13511 passed, 129 skipped, 6 failed; all 6 are intest/unit/tooling/windows_registry_qualification_test.dartand fail withProcessException: pwsh: No such file or directory(PowerShell is not installed on this host; CI has it). Same 6 indart test -p vm test/unit/tooling/.dart test -p chrome --exclude-tags local-only: passcoverage-lib: lcov 93.73%, threshold 70 mettool/testing/run_template_parity_suites.sh: passlitert-lm-json-schemawith Gemma 4 E2B, CPU and GPU, PASS.gguf-chat-features-smokewith Qwen3.5-2B Q4_K_M: required tool calls pass;toolCallWithThinkingBudgetfails byte-identically on main33e00f5a, so it is pre-existing and filed separately.Matrix Evidence
static-format-analyzeroot-vmpwsh-missing testsroot-chromecoverage-libhigh-risk-exact-head-independent-qaa9c77725llamadart-evidence/pr-1912/structured-output-adversarialllamadart-evidence/pr-N/Review Notes
a9c77725(0 P1/P2).a9c77725258e8d69d48231b11047bda1f91b1ce0; no reruns.High-risk regression review
git diff --name-only --no-renames origin/main...HEAD | dart run tool/testing/classify_high_risk_changes.dart:a9c77725, 0 P1/P2, evaluator exit 2 (unverifiedPrerequisites)a9c77725258e8d69d48231b11047bda1f91b1ce0/33e00f5a7a85083664843c3d5fdec2f1e6dcab53llamadart-evidence/pr-N/)compiled_grammar_*waiver above