Repository navigation
Add a LiteRT auto validation profile and record the Galaxy S24 CPU retry run - #1904
Merged
Merged
Conversation
…1458) Remote runs require a clean committed bundle, so the S24 ComputeDevice.auto check needs a committed profile instead of a local copy. Co-Authored-By: Claude <[email protected]>
This was referenced Nov 10, 2026
Contributor
|
Chat app preview removed for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat-litert-auto, thechat-litert-gpuprofile underbackend: auto, so the Galaxy S24ComputeDevice.autoGPU-to-CPU retry can run from a clean committed bundle. Remote runs now refuse dirty bundles, so the local profile copy in the #1856 recipe no longer works.doc/cross_platform_validation.md. Result: GPU refused, one warning per engine, CPU retry, 16/17 PASS.automapping that item 4 asked for was already fixed in #1658. I re-checked it ond739cfdb8: the testLiteRT profiles preserve automatic and explicit device selectionpasses, and anauto->GpuBackend.cpumutant fails it (Expected: GpuBackend.auto, Actual: GpuBackend.cpu).Production-readiness scope
0.19.1-2exposes no performance counters, soC08.cancelis NOT_RUN. It also happens on macOS CPU, so the retry does not cause it.Completeness checklist
embedding_audit_test.dart; theautomapping test exists from fix: preserve automatic LiteRT backend on context recreation #1658.)PR type guidance
automapping fix is already onmain(fix: preserve automatic LiteRT backend on context recreation #1658).Test Plan
dart run tool/prepare_workspace.dart(clean ond739cfdb8)dart format --output=none --set-exit-if-changed .(0 changed)dart analyze: N/A at the root, since only the package changed.packages/llamadart_validationdart analyze: no issues.dart test -p vm -j 1 --exclude-tags local-only: Markdown-selected root suites (tool/ci/markdown_test_suites.txt) pluslitert_lm_tokenizer_fixture_test.dartpass, 815 passed and 4 skipped. The full suite runs in CI.dart test -p chrome --exclude-tags local-only: N/A, no web orlib/change.coverage-libmatrix row: N/A, nolib/change.packages/llamadart_validationdart test -p vm: 642 passed.example/chat_appflutter test test/validation_app_test.dart: 3 passed (bundled profile list). Firebase device run below.Matrix Evidence
static-format-analyzevalidation-harnessroot-vmroot-chromecoverage-liblib/changeComputeDevice.autoGPU failure and CPU retrySC-51EAPI 36, Adreno 750; Qwen3 0.6B legacy LiteRT artifact; LiteRT-LM0.19.1-2; source3f6338b50(clean)matrix-1da3zj25gmeu1; details belowhigh-risk-exact-head-independent-qastandardReview Notes
matrix-1da3zj25gmeu1, test time 213 s):C09.reloadandC12.recovery.FAILED_PRECONDITION (9): Android GPU safety restriction: observed Vulkan device vendor=20803 ... maxStorageBufferRange=134217728 ... 155582464-byte constant ... Use CPU.[WARN] LiteRT-LM could not create a GPU engine under ComputeDevice.auto; retrying on the CPU. Load with ComputeDevice.cpu to skip the GPU, or ComputeDevice.gpu to fail instead.once per engine (3 in total), then XNNPACK created a CPU engine.LiteRT-LM cpuwith 0 GPU layers.C01.loadstill reportsgpubecause engine creation is deferred.matrix-1tcmnx5y9bnqv, test time 602 s) stopped at the harness's 10-minute model download deadline at 260777210 of 614236160 bytes, before any case ran. The download ran at about 3 MB/s, then slowed to about 100 KB/s. I retried once.chat-litert-cpurun atd739cfdb8has the sameC08.cancelNOT_RUN with null counters. At0.18.1-4, three Linux CPU runs passed with counters.7584d2e141bc33b13ea25043cad3f646fbd151e5.High-risk regression review