Repository navigation
Conversation
…rd the empty raw prompt refusal (#1861)
… pin unnamed argument errors (#1861)
This was referenced Nov 10, 2026
leehack
added a commit
that referenced
this pull request
Nov 10, 2026
Owner
Author
|
Landed on main via batch integration PR #1895 (rebase merge, main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LlamaArgumentException.namewhen the LiteRT-LM worker reports an argument error (LiteRtLmErrorResponse.argumentName, rebuilt in_exceptionForErrorResponse).invalidValueis not carried: it is an arbitrary object and may not cross the isolate port.Production-readiness scope
generate()geterror.name == 'prompt'through the worker, and a message that names the case.Completeness checklist
PR type guidance
_exceptionForErrorResponserebuiltLlamaArgumentExceptionfrom the message only. Tests:worker_messages_test.dart(name captured) andlitert_lm_backend_test.dart(name rebuilt). Platforms: native LiteRT-LM.Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm -j 1 test/unit/backends/litert_lm(1536 pass), isolatedTMPDIRdart test -p chromeN/A: native-only filescoverage-libN/A: changed lines are all executed by the new testsMatrix Evidence
Mutants killed: drop
name:in_exceptionForErrorResponse; dropargumentName:inLiteRtLmErrorResponse._from; default the name to'prompt'at either end (unnamed errors stay unnamed); invert the empty/start-token-only branch.Review Notes
High-risk regression review
Refs #1861, Refs #1874