Skip to content

Align example Flutter floors with the core package's 3.38.6 - #1848

Closed
leehack wants to merge 1 commit into
mainfrom
l2-flutter-floor
Closed

leehack wants to merge 1 commit into
mainfrom
l2-flutter-floor

Conversation

@leehack

@leehack leehack commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Example apps (chat_app, laya_tetris, laya_command_bar) now declare flutter: ^3.38.6; example/README.md and example/chat_app/README.md say 3.38.6. They depend on core llamadart (sdk: ^3.10.7), and 3.38.6 is the first Flutter with Dart 3.10.7.
  • True floor of chat_app: 3.38.6. Its lock's dart: ">=3.11.0-0" comes from the Flutter SDK's own packages (flutter, flutter_test, integration_test declare ^3.11.0-0 in the SDK that generated the lock, 3.47.1), not from a hosted dependency: every hosted package in the lock declares at most ^3.10.x, and audioplayers/synchronized are pinned below the versions that need Flutter 3.44 / Dart 3.11. Locks are unchanged by prepare_workspace.

Refs #1837 #1845

Production-readiness scope

  • User-facing scope: Example apps and their READMEs state the floor that actually resolves.
  • Supported platforms/paths: Flutter examples; docs.
  • Unsupported or intentionally unavailable paths: Flutter 3.38.0-3.38.5 already failed pub resolution (core needs Dart 3.10.7); now declared up front.
  • Out of scope / follow-ups: None. CONTRIBUTING.md floor is in the sibling PR (it is high-risk-classified).

Completeness checklist

  • Declared scope is fully implemented, or explicitly reduced above.
  • Unsupported platform/option combinations fail loudly with actionable diagnostics or are clearly documented as unavailable. (N/A: tooling/docs only)
  • Public API docs, README/website docs, examples, support matrices, and changelog entries are updated where relevant. (changelog N/A: not user-visible)
  • Regression coverage covers the original issue plus key negative/version-skew paths where relevant.
  • Public capability changes update the validation coverage registry. (N/A: no capability change)
  • Security/privacy review completed: no secrets, tokens, signed URLs or secret-bearing paths added.
  • Follow-up work is tracked in GitHub Issues, or marked "None" above.

PR type guidance

  • Docs-only PR: no runtime behavior change; pubspec constraint raised to what already resolved. Validated with the markdown-selected root suites and prepare_workspace.dart (all example packages resolve).

Test Plan

  • dart run tool/prepare_workspace.dart (no tracked lock changes)
  • dart format --output=none --set-exit-if-changed .
  • dart analyze
  • Markdown-selected root suites (tool/ci/markdown_test_suites.txt)
  • dart test -p chrome -- N/A: no code
  • coverage-lib -- N/A: no lib/ change
  • Other: example apps' own tests -- N/A: constraint-only change, CI example lanes run them

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
static-format-analyze format, analyze macOS, Flutter 3.47.1 Pass clean
markdown suites docs wording tests macOS VM Pass 729 tests

Review Notes

  • Independent review status: N/A for trivial constraint/docs change
  • CI status / head SHA: pending / 46d7e228

High-risk regression review

  • Classification: standard
  • Implementation task: N/A
  • Independent blocking QA task: N/A
  • Exact head / current base: N/A
  • Production-branch deletion, bypass, or miswire proof: N/A
  • Affected-family real-model/artifact evidence: N/A
  • Explicit unavailable-family or other N/A evidence: N/A
  • Known PR-caused P1 regressions: 0
  • Unresolved review threads: 0

@leehack

leehack commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

Landed through the 0.19.2 batch integration PR #1870 (rebase merge, one commit per constituent; this PR's pinned head was audited/CI-gated there).

@leehack leehack closed this Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1848.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant