Repository navigation
Conversation
leehack
added a commit
that referenced
this pull request
Nov 9, 2026
Owner
Author
|
Landed through the 0.19.2 batch integration PR #1870 (rebase merge, one commit per constituent; this PR's pinned head was audited/CI-gated there). |
Contributor
|
Chat app preview removed for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production-readiness scope
tool/ci/supervise_chrome_test.py) on Linux.Completeness checklist
PR type guidance
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm -j 1 --exclude-tags local-onlyN/A: Python-only changedart test -p chrome --exclude-tags local-onlyN/A: Python-only changecoverage-libN/A: nolib/changepython -m unittest test.ci.test_supervise_chrome_testin python:3.12-slim (git, jq installed): 39 tests OKMatrix Evidence
Mutation check (
tool/ci/supervise_chrome_test.py:430os.set_blocking(2, blocking)->os.set_blocking(2, True)): the newtest_stale_reporter_error_keeps_a_non_blocking_caller_stderr_non_blockingfails (1 failure, all else pass); unmutated: OK.Review Notes
High-risk regression review
Refs #1837 #1845