Skip to content

Note the Vulkan Tesla T4 placement measurement in the image guide - #1586

Merged
leehack merged 1 commit into
mainfrom
docs/image-guide-vulkan-evidence
Oct 29, 2026
Merged

leehack merged 1 commit into
mainfrom
docs/image-guide-vulkan-evidence

Conversation

@leehack

@leehack leehack commented Oct 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • The image-generation guide's module placement section said Vulkan had not been measured. It now says placement was measured with SD-Turbo on one Linux x64 Vulkan Tesla T4, which matches the 0.17.0 release notes and the support matrix (#1551). Two-GPU hosts and the larger models remain unmeasured. This follows up the #1585 audit (P3).

Production-readiness scope

  • User-facing scope: docs wording only.
  • Supported platforms/paths: docs only.
  • Unsupported or intentionally unavailable paths: N/A, wording only.
  • Out of scope / follow-ups: None. The frozen version-0.17.0 snapshot keeps the old line; that is versioned docs, which stay as published.

Completeness checklist

  • Declared scope is fully implemented, or explicitly reduced above.
  • Unsupported platform/option combinations fail loudly with actionable diagnostics or are clearly documented as unavailable. (N/A, docs only.)
  • Public API docs, README/website docs, examples, support matrices, and changelog entries are updated where relevant. (No changelog entry, docs wording only.)
  • Regression coverage covers the original issue plus key negative/version-skew paths where relevant. (N/A, docs only.)
  • Public capability changes update the validation coverage registry with a pack or a reasoned, issue-linked exemption; inventory checks pass (or N/A with scope). (N/A, no capability change.)
  • Security/privacy review completed: no secrets, bearer tokens, signed URLs, or raw secret-bearing paths leak through logs, cache keys, metadata, errors, or snapshots.
  • Follow-up work that is useful but not required for this PR is tracked in GitHub Issues, or explicitly marked "None" above.

PR type guidance

  • Docs-only PR: no runtime behavior changes. CI's docs build checks links.

Test Plan

  • dart run tool/prepare_workspace.dart: N/A, docs only.
  • dart format --output=none --set-exit-if-changed .: N/A, Markdown only.
  • dart analyze: N/A, docs only.
  • dart test -p vm -j 1 --exclude-tags local-only: N/A, docs only.
  • dart test -p chrome --exclude-tags local-only: N/A, docs only.
  • Other targeted/local-only validation: CI docs build.

Matrix Evidence

Matrix row Scope covered Platform / model / backend Result Evidence / notes
N/A docs wording N/A N/A Matches the evidence that the #1585 audit cited (#1551, Tesla T4 run).

Review Notes

  • Independent review status: N/A, trivial docs-only change.
  • CI status / head SHA: pending.

High-risk regression review

  • Classification: standard
  • Implementation task: N/A
  • Independent blocking QA task: N/A
  • Exact head / current base: N/A

@leehack
leehack merged commit 79c082f into main Oct 29, 2026
29 checks passed
@leehack
leehack deleted the docs/image-guide-vulkan-evidence branch October 29, 2026 12:23
@github-actions

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-1586.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant