Repository navigation
Sweep 1565: forced-open Seed-OSS verbatim thought, hermetic SD hook test, extraction marker follow-ups - #1575
Merged
Merged
Conversation
…iffusion hook test hermetic, and pin the extraction marker
…ighten marker tests and docs
Contributor
|
Chat app preview removed for |
This was referenced Oct 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears these items on tracker #1565 (not the stable genkit item #1574):
parseRenderedDartdoc (#1573 audit): engine equivalence needsparseToolCallsset like the engine, the engine's partial reparse after a PEG failure, copies (constructor,fromJson, isolate transfer) losing the marks, and reasoning chunks dropped with thinking off. Class-doc example fixed.build_hook_stable_diffusion_integration_test.dart("the stable_diffusion companion selects and links it in process"): seeds the LiteRT-LM macOS arm64 cache from fake libraries. Passes with outbound network denied (sandbox-exec); onmainit fails there downloadinglitert-lm-native-runtime-macos-arm64-v0.18.1-4.tar.gz.</seed:think>as generated (keepsForcedThoughtVerbatim, as DeepSeek V3, Cohere2 MoE, Qwen3-Coder XML), so a repeated<seed:think>and text before it stay in the reasoning, as llama.cpp 620d2225 keeps them. Stream and parse agree; a thought closed for thinking off and later reached by a thinking tag streams like Cohere2 MoE._endsUnopenedSeedOssThought(B12 too: a NBSP-led public parse now pins its reasoning).Production-readiness scope
<seed:think>Planis trimmed (llama.cpp keeps leading space too); content, tags and later text are identical.ChatTemplateEngine.parseon the stock Seed-OSS template (#1565, 0.18 candidate).Completeness checklist
PR type guidance
closed_thought_upstream_test.dart(values from the llama.cpp 620d2225 oracle), hook and marker tests. Platforms: all.Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyze;dart run tool/testing/check_platform_boundaries.dartTMPDIR=$(mktemp -d) dart test -p vm -j 1 --exclude-tags local-only: +9799 ~8, all passed (re-run at the audit-fix head)dart test -p chrome --exclude-tags local-only test/unit/core/template test/unit/core/engine: +2139 ~1, all passedtool/testing/run_template_parity_suites.shexit 0;test/unit/tooling+1240 ~5sandbox-execdenynetwork-outbound, wholebuild_hook_stable_diffusion_integration_test.dart+34 passed (fails onmainwith the LiteRT-LM download)main's parser; each new hook test fails against its mutant belowMatrix Evidence
static-format-analyzeroot-vmroot-chromeoracle176e12e4cvs headhigh-risk-exact-head-independent-qa/opt/UnitySrc/personal/llama/llamadart-evidence/pr-1575/evidence-1575-0629111.jsonMutants (all killed, incl. audit H3 wrong refresh digest and uncaught refresh failure): A1, A6, A9, A13, A14, A15 (no marker refresh), A16 (always warn); Seed-OSS: old forced-open parse, trait off, stream marker branch off, no ASCII trim, Unicode
trimLeft()in_endsUnopenedSeedOssThought.Review Notes
High-risk regression review
chat_format_registry.dart; mutant with the trait off is killed)