Repository navigation
Add a compatible session clock for reproducible template dates - #1383
Merged
Merged
Conversation
Owner
Author
|
Parked out of 0.16.2: the new exported |
This was referenced Oct 25, 2026
leehack
marked this pull request as ready for review
October 25, 2026 18:30
Contributor
|
Chat app preview removed for |
…sion # Conflicts: # packages/llamadart_validation/assets/capability_coverage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
TemplateTimeChatSessionso each request uses one configured time for context budgeting and generation, including one-shot, structured-output and tool-loop paths. Apply explicit template clocks tostrftime_nowas well as date globals.Closes #859. Uses published Dinja 1.3.2 from dinja#40.
Production-readiness scope
Completeness checklist
PR type guidance
Test Plan
unverifiedPrerequisites; external enforcement is unconfigured, not claimed satisfied.49beb9f1, including desktop bundles on Linux/macOS/Windows. The actual registry conflict with newly merged main is resolved atb22350ac; new-head CI is pending and combined-main verification follows the user-approved individual merges. Core run.Matrix Evidence
Review Notes
Head
b22350ac352132954d37caaf21d1e57d900d5126; current baseb373a77ba56b134a6ff8a542130d684e226e4415. Dinja prerequisite is merged, published and archive-verified. Feature audit, CI, consumer tests/docs and clean desktop bundle verification passed at49beb9f1. After #1425/#1424 landed, GitHub reported an actual registry conflict; both complete mappings were preserved. A bounded independent merge-resolution review is refreshed atb22350ac. Current-head CI is pending rather than represented as passed; the user requested merge first and verify combined main afterward.High-risk regression review
template_clock_independent_audit; accepted final head. Evidence/private/tmp/template-clock-independent-audit/{REPORT.md,evidence-input.json,evaluation.json}.