Repository navigation
Follow up #213 review notes: fail-closed comment, pauseGrammar failure docs, smoke scope - #214
Merged
Merged
Conversation
…moke repro (#213 follow-up)
17 of 20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #213 P3 review notes. Comments and docs only; no behaviour change.
generation.inc: the-INFINITYfail-closed comment now also covers a subnormaltempwith no budget.docs/api.md: a kept grammar that rejects the forced end tag fails withGrammar rejected every candidate token.scripts/smoke/grammar.mjs,CONTRIBUTING.md: the end-tag-rejecting check reproduces the original bug only on Qwen3.5; the tiny model passes either way. CI already runs the smoke with both models, so no new smoke.npm run check:js(603 pass) andverify_ci_reliability.mjspass. No candidate, qualification or publish workflow dispatched.