Repository navigation
test(server): finish workflow reads before changing transcripts - #388
Conversation
Use the existing frame acknowledgement before changing transcript fixtures, retaining retry timestamp assertions. Carry-Group: upstream-bugfixes Carry-Upstream: https://redirect.github.com/pingdotgg/t3code/pull/18192 (8a5ec7b) Carry-Observation: Await prior workflow snapshot reads before changing transcript fixtures; production behavior and assertions are unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
The settled Claude workflow test can rewrite transcript files while an earlier snapshot is still reading them. An answer from attempt 1 can satisfy the retry wait before attempt 2 is collected, making the unchanged timestamp assertion observe the earlier event. This interrupted full package validation.
Await the existing frame-processing handshake for snapshots 001015 and 001016 before changing the next transcript. The two-line fixture repair changes no production code and retains the original assertions.
Upstream contribution: https://redirect.github.com/pingdotgg/t3code/pull/18192, source
8a5ec7b1cc7ddb9206a4852b95e10e1430692dcb. LastCode delivery is independent of upstream acceptance.Validation: all 230 Claude adapter tests pass with
vp test run apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts --maxWorkers=1 --maxConcurrency=1; targeted lint andgit diff --checkpass. The original named case passed once before the change; no deterministic reproduction of the intermittent full-suite failure is claimed. All 227 adapter tests and targeted lint also pass on the upstream branch. Required GitHub checks validate this exact LastCode head and base.Implemented with GPT-6.1 Sol in the Codex harness; diagnosis and fixture repair by Astra High.