Port React widget stability fixes to Vue - #11
Conversation
- ChartWidget (Vue): per-bar colors when a bar dataset's backgroundColor is an array. - ChartWidget (Vue + React): pie/doughnut charts fall back to the palette for an empty color array. - StatsOverviewWidget (Vue): fall back to the primary chart color for unknown colors, draw single-value line charts as a flat line, and render linked stat cards as Inertia links. - WidgetRenderer (Vue): one polling timer per interval, re-created when the widget list's polling configuration or queryRoute changes, and cleared on unmount. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Vue and React chart widgets now handle per-bar colors and empty color arrays. Stat cards use Inertia links, single-value line charts are guarded, and widget polling uses grouped timers. ChangesWidget rendering updates
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Polling continues to reload the widget payload correctly when an enabled query route changes; no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ports the React fixes from 84a03b8 to the Vue stack, and fixes one more bug of the same class in both stacks.
Fixes
backgroundColorget one colour per bar (Chart.js convention).backgroundColoris an empty array (previously undefined fills).primary(previously a render error)<Link>s, so they are focusable and keyboard-activatablequeryRoutechanges, including after a reload changes the widget listVerification
vendor/bin/pest: 74 passednpx tsc --noEmit -p tsconfig.laravilt.json: 0 errors🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes