Fix plugin dependency handling and generated stubs - #47
Merged
Merged
Conversation
…d and plugin stubs Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
Warning Review limit reachedNext included review available in 22 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
dependenciesSatisfied(),getDependencies()andgetName(), which neither thePlugincontract norPluginProviderdefines, so it was fatal as soon as discovery found a plugin.PluginProvidernow has default dependency methods, and callers check the method exists before calling it.__dirname, but the generated package is"type": "module", so Vite crashed loading it. It now usesfileURLToPath(import.meta.url), like the React stub.{{ name }}/{{ config }}placeholders and a missingProcessimport in generated install commands.Panel/Plugin, which is incompatible withPluginProvider::register(Laravilt\Panel\Panel), so every generated plugin was fatal.Verification
vendor/bin/pest: 48 passed (baseline 43), with newPluginManagerTest,GeneratedStubsTest, and a tightenedJsFeatureTest.🤖 Generated with Claude Code