Skip to content

Fix plugin dependency handling and generated stubs - #47

Merged
fadymondy merged 1 commit into
masterfrom
fix/stability
Sep 15, 2026
Merged

fadymondy merged 1 commit into
masterfrom
fix/stability

Conversation

@fadymondy

Copy link
Copy Markdown
Contributor

Fixes

  • PluginManager / PluginManifest / PluginProvider: called dependenciesSatisfied(), getDependencies() and getName(), which neither the Plugin contract nor PluginProvider defines, so it was fatal as soon as discovery found a plugin. PluginProvider now has default dependency methods, and callers check the method exists before calling it.
  • vite.plugin.stub: the Vue stub used __dirname, but the generated package is "type": "module", so Vite crashed loading it. It now uses fileURLToPath(import.meta.url), like the React stub.
  • install-command.stub / InstallCommandFeature: unfilled {{ name }} / {{ config }} placeholders and a missing Process import in generated install commands.
  • plugin.stub: used Filament's Panel / Plugin, which is incompatible with PluginProvider::register(Laravilt\Panel\Panel), so every generated plugin was fatal.
  • MakePluginCommand: an interactively entered name left the default title and description empty. The "JS assets" label no longer says Vue only.

Verification

  • vendor/bin/pest: 48 passed (baseline 43), with new PluginManagerTest, GeneratedStubsTest, and a tightened JsFeatureTest.
  • pint clean.

🤖 Generated with Claude Code

…d and plugin stubs

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a47cdb1d-6ccf-418e-81c4-c42539e12f49

📥 Commits

Reviewing files that changed from the base of the PR and between 46cdf66 and a896fc0.

📒 Files selected for processing (11)
  • src/Commands/MakePluginCommand.php
  • src/Features/InstallCommandFeature.php
  • src/PluginProvider.php
  • src/Stubs/install-command.stub
  • src/Stubs/plugin.stub
  • src/Stubs/vite.plugin.stub
  • src/Support/PluginManager.php
  • src/Support/PluginManifest.php
  • tests/Unit/Features/GeneratedStubsTest.php
  • tests/Unit/Features/JsFeatureTest.php
  • tests/Unit/PluginManagerTest.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fadymondy
fadymondy merged commit 5bb37a7 into master Sep 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant