Port React profile fixes to Vue; fix panelId and connected-accounts error state - #15
Merged
Merged
Conversation
…s error state Vue ports of 6c6bfbe: - Confirm before the account-deletion DELETE visit (onBefore; the old @submit handler never ran because <Form> owns submit). - Send excludeCredentials when registering a passkey so the same authenticator cannot be registered twice; drop the debug log. - Keep the 2FA method restored from setup data instead of resetting it to the first provider on mount. - Only strip the trailing /register when building the passkey delete URL. - Default sessions to an empty array when the response has none. - Align AuthSocialProvider with the provider payload (icon, colorClasses) and use it in SocialLogin and BottomAuthHook. Both stacks: - Profile sections take an optional panelId, falling back to the page's top-level panelId prop, instead of always calling the 'user' panel; ProfilePage forwards it. - ConnectedAccounts: a failed load shows only the error, not "no providers" plus the error. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (29)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Panel routes live under the panel path, which can differ from the panel id, so every profile request (API tokens, sessions, passkeys, 2FA, connected accounts) broke for a panel with a custom path. Use the path the panel package already shares with every page, falling back to the id, in both the Vue and React composables. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vue ports of 6c6bfbe
onBeforeon<Form>; the previous@submitconfirm never ran).excludeCredentialsagain, so the same device can't be registered twice; debug log removed./register.AuthSocialProvidermatches the server payload (icon,colorClasses) and is used by SocialLogin and BottomAuthHook.Both stacks
panelId, falling back to the page's top-levelpanelIdprop (then'user'); ProfilePage forwards it. Previously non-userpanels called/user/profile/....Note: the composables still build URLs as
/{panelId}/profile/..., while routes are registered under the panel path. This works when id and path match; server-provided URLs would be the complete fix.Verification
vendor/bin/pest: 38 passednpx tsc --noEmit -p tsconfig.laravilt.json: 0 errors🤖 Generated with Claude Code