Repository navigation
Logger simplify - #355
Open
jacob-moore22 wants to merge 3 commits into
Open
Logger simplify#355jacob-moore22 wants to merge 3 commits into
jacob-moore22 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies
fierro::Loggerand removes unused#includes across the multiphysics app.Logger (
common/include/logger.hpp, newcommon/src/logger.cpp).cpp. Removed the GPU-kernel logging path, which nothing used (Handle,FLOG_DEV,log_handle(), device ring buffers,StdoutTarget,all_ranks(),set_file_prefix). The header no longer includes Kokkos.Trace < Debug < Info < Warn < Error < Off, withtrace/debug/info/warn/error,log(lvl, ...),set_level()andlevel().__attribute__((format(printf, ...))), so call sites now get compile-time format checking. This fixes the clang-Wformat-securitywarnings that came from the oldlogger.hpp:418.Fierro_log_<rank>, and rank 0 also writes to stdout. Lines are tagged[rank N][LEVEL].flush()is no longer collective, so it is safe in loops whose trip count differs between ranks.Solver::log_handle()is removed.Solver::logandset_loggerare unchanged, and noinfo/error/flushcall sites changed.Header cleanup
#includes from 36 files. The candidates came fromclang-include-cleaner. Removals that were only safe through transitive includes were put back, and everymatar.h/ELEMENTS.hinclude was kept.logger.hppinclude fromregion_fill.hpp.Behavior notes
flush(). The content and order are the same.No new dependencies.
Type of change
Please select all relevant options
How Has This Been Tested?
Fierro, thenregression_tests/test_refactor.pyagainstbuild/app/Fierro. 35/35 tests pass, and the results match the pre-change baseline.mpirun -np 1and-np 4(--oversubscribe).Fierro_log_0..3are created with each rank's lines, and only rank 0 prints to stdout.set_level(LogLevel::Warn)hidesinfolines whilewarnanderrorlines still print.Not yet tested: clang/Apple clang, CUDA/HIP builds, and the regression suite on more than one rank.
Test Configuration:
Checklist: