Repository navigation
chore(deps): bump the vitest group across 1 directory with 2 updates - #959
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
github-actions
Bot
added
the
low-risk-change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
langwatch-agent
added
ci-green
langwatch-agent
left a comment
langwatch-agent
left a comment
There was a problem hiding this comment.
No blocking issue found in the static dependency and lockfile review. This updates Vitest without source, workflow, or permission changes. Existing CI is green. I did not execute PR code.
LangWatch-Review: verdict=clean sha=1e9ded0d795b79a683796f838eaf34064e0f69bc p0=0 p1=0 p2=0 p3=0
1e9ded0 to
4ee0649
Compare
github-actions
Bot
removed
the
low-risk-change
langwatch-agent
left a comment
langwatch-agent
left a comment
There was a problem hiding this comment.
1 actionable finding; details inline.
Reviewed the changed code and relevant base callers/tests, with existing CI logs where available. The findings are not based on executing the PR.
External-contribution safety: reused the existing worktree; no PR code, dependency installation, package scripts, or live secret-bearing tests were executed. This is a COMMENT review, not approval or a claim that all CI passed.
LangWatch-Review: verdict=findings sha=4ee0649a785907a6f61c281d335c95bad1064ecc p0=0 p1=1 p2=0 p3=0
| "typescript": "^5.9.3", | ||
| "typescript-eslint": "^8.48.0", | ||
| "vitest": "^4.0.14" | ||
| "vitest": "^5.0.0" |
There was a problem hiding this comment.
P1 · Upgrade the BDD adapter before moving to Vitest 5
-
What you're looking at. Vitest changes to 5.0.0 while @amiceli/vitest-cucumber stays at 7.0.0.
-
Why it's scary. The head's ci-checks job repeatedly crashes inside describeFeature with 'Cannot read properties of undefined (reading config)' across judge and voice suites. Those scenarios cannot even be collected under the new runner. Use a compatible BDD adapter or keep Vitest 4 until the adapter migration is included; verify collection and execution of the feature-bound suites. CI evidence.
4ee0649 to
bc56a34
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
langwatch-agent
left a comment
langwatch-agent
left a comment
There was a problem hiding this comment.
1 P2 dependency-migration finding; details inline. Static review of the current head, base consumers and CI logs. No PR code, installs or package scripts executed.
LangWatch-Review: verdict=findings sha=bc56a34f3de6105a10c9b1f76552b0a020e498e7 p0=0 p1=0 p2=1 p3=0
| "typescript": "^5.9.3", | ||
| "typescript-eslint": "^8.48.0", | ||
| "vitest": "^4.0.14" | ||
| "vitest": "^5.0.0" |
There was a problem hiding this comment.
P2 · Keep the feature-test adapter compatible with Vitest
-
What you're looking at. The runner upgrades to Vitest 5 while @amiceli/vitest-cucumber stays at 7.0.0.
-
Why it's scary. Current-head CI job 104149644669 fails loading numerous feature suites: describeFeature reads config from an undefined runner object, including transcribe, TTS, judge and remote-trace suites. Their behavioral assertions never run. Upgrade/migrate the adapter together with the runner, or keep Vitest 4, and require the feature-backed suites to load and pass.
bc56a34 to
a68cc7e
Compare
langwatch-agent
left a comment
langwatch-agent
left a comment
There was a problem hiding this comment.
One P2 remains on this head; see inline evidence from the current CI run. Static review only, with no contributor code or package scripts executed locally.
LangWatch-Review: verdict=findings sha=a68cc7e7f909da397ecb077d275b7ffbff3bb988 p0=0 p1=0 p2=1 p3=0
| "typescript": "^5.9.3", | ||
| "typescript-eslint": "^8.48.0", | ||
| "vitest": "^4.0.14" | ||
| "vitest": "^5.0.1" |
There was a problem hiding this comment.
P2 · Keep the feature-test adapter compatible with Vitest
-
What you're looking at. This upgrades Vitest to 5.0.1 while @amiceli/vitest-cucumber remains at 7.0.0.
-
Why it's scary. Current-head CI still crashes in describeFeature with an undefined config across multiple voice and judge suites. Their assertions never run. Upgrade the adapter with the runner, or retain Vitest 4, then verify the feature-bound suites collect and execute. CI evidence.
a68cc7e to
7383b57
Compare
langwatch-agent
left a comment
langwatch-agent
left a comment
There was a problem hiding this comment.
One P2 remains on this head; details and current CI evidence inline. Static review only; no contributor code, installs or package scripts executed locally.
LangWatch-Review: verdict=findings sha=7383b578a31c8aec1013008024d8ae5452f825cb p0=0 p1=0 p2=1 p3=0
| "typescript": "^5.9.3", | ||
| "typescript-eslint": "^8.48.0", | ||
| "vitest": "^4.0.14" | ||
| "vitest": "^5.0.2" |
There was a problem hiding this comment.
P2 · Keep the feature-test adapter compatible with Vitest
-
What you're looking at. Vitest moves to 5.0.2 while @amiceli/vitest-cucumber remains at 7.0.0.
-
Why it's scary. The current Node 24 CI job crashes inside describeFeature with an undefined config across voice, connected-agent and judge suites, before their assertions run. The earlier compatibility finding remains. Upgrade the adapter with the runner or keep a compatible runner, and verify these suites collect and execute. Current CI evidence.
Bumps the vitest group with 2 updates in the /javascript directory: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `@vitest/coverage-v8` from 4.1.10 to 5.0.3 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.3/packages/coverage-v8) Updates `vitest` from 4.1.10 to 5.0.3 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.3/packages/vitest) --- updated-dependencies: - dependency-name: "@vitest/coverage-v8" dependency-version: 4.1.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: vitest - dependency-name: vitest dependency-version: 4.1.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: vitest ... Signed-off-by: dependabot[bot] <[email protected]>
7383b57 to
b443057
Compare
|
Automated low-risk assessment This PR was evaluated against the repository's Low-Risk Pull Requests procedure and does not qualify as low risk.
This PR requires a manual review before merging. |
langwatch-agent
left a comment
langwatch-agent
left a comment
There was a problem hiding this comment.
PR Reviewer: 1 P2 finding, detailed inline. Static diff/current-base review and existing CI only; no PR code executed.
LangWatch-Review: verdict=findings sha=b4430573b631f5d56c96187dfb6d836f26183ded p0=0 p1=0 p2=1 p3=0
| "typescript": "^5.9.3", | ||
| "typescript-eslint": "^8.48.0", | ||
| "vitest": "^4.0.14" | ||
| "vitest": "^5.0.3" |
There was a problem hiding this comment.
P2 · Preserve the Cucumber suite collector when upgrading Vitest
-
What you're looking at. Vitest moves to 5.0.3 while @amiceli/vitest-cucumber remains 7.0.0.
-
Why it's scary. Current CI fails collecting judge and voice suites in describeFeature with
Cannot read properties of undefined (reading 'config'). Those suites do not execute. Main still uses Vitest 4 with this adapter. Upgrade or adapt the Cucumber integration together, or defer Vitest 5. Evidence: https://github.com/langwatch/scenario/actions/runs/38511429025/job/115680646548.
This branch has not been deployed
1 participant
Bumps the vitest group with 2 updates in the /javascript directory: @vitest/coverage-v8 and vitest.
Updates
@vitest/coverage-v8from 4.1.10 to 5.0.3Release notes
Sourced from @vitest/coverage-v8's releases.
... (truncated)
Commits
33cadeachore: release v5.0.3 (#11409)a029e76chore: migrate to oxc (#11367)428e2e5chore: release v5.0.2 (#11357)03630a5chore: release v5.0.1 (#11275)f441c6fchore: release v5.0.0 (#11130)c4473e4fix(coverage): prevent crash on/@fs/prepended virtual files (#11119)897f51fchore: release v5.0.0-rc.4 (#11107)7db80dcchore: release v5.0.0-rc.3 (#11089)5f6a5e8feat(coverage): switch to@vitest/istanbuljspackages (#11053)c6174a6fix(coverage): v8 to ignore Vite SSR's generated import bindings (#11023)Updates
vitestfrom 4.1.10 to 5.0.3Release notes
Sourced from vitest's releases.
... (truncated)
Commits
33cadeachore: release v5.0.3 (#11409)346d389fix(vm): don't reuse scripts across vite environments (#11395)f6c9a49fix(deps): pinwhy-is-node-runningto3.2.1to avoid users running into `...062c75dchore: fix standalone docs build, update exports maps (#11394)caf2887fix(vm): do not optimize deps from index.html (fix #11329) (#11360)50312ebfix(pool): preserve unique pool ids whengroupOrderis set (#11392)7c36748fix(browser): ignore page crash while cancelling (#11386)92ba7fcfix: scope cache key generators to projects (fix #11281) (#11301)38f9885fix(cache): revalidate imports of cached modules (#11381)b24585ffix: don't retry whentest.failsexpectedly failed (#11219)