fix: cap cache durations at one year#96
Open
lan17 wants to merge 1 commit into
Open
Conversation
lan17
marked this pull request as ready for review
July 26, 2026 17:56
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
DialCache previously accepted any positive safe-integer TTL even though local, Redis, tracked-watermark, and invalidation paths later multiplied or added those values independently. That made rejection timing inconsistent and allowed fallback serialization to happen before an oversized Redis TTL was rejected.
This change gives every duration path one simple supported maximum. Static/default TTLs reject before fallback work, malformed dynamic TTLs preserve the existing
invalid_ttlfail-open behavior, and invalidations reject before Redis mutation. Existing inputs within 365 days are unchanged; larger inputs are now explicitly unsupported.Validation
corepack pnpm install --frozen-lockfilecorepack pnpm check(289 unit tests, typecheck, coverage, build, packed consumers)corepack pnpm test:integration(77 Redis 6.2, Valkey 8, and Redis Cluster tests)git diff --checkCloses #33