test: e2e auto-heal 2026-09-04 — antd select drift in admin model card, nav strict-mode, CSV bulk-create dropdown - #9423
Merged
Conversation
…d, nav strict-mode, CSV bulk-create dropdown
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The skipped coverage report is stale, and the create spec contains formatting and positional-selector issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates E2E locators for Astryx-rendered controls and records backend-blocked model-card scenarios.
Changes:
- Replaces obsolete Ant Design selectors with semantic locators.
- Handles CSV keypair confirmation flow.
- Marks six backend-blocked model-card tests as
fixme.
File summaries
| File | Description |
|---|---|
e2e/serving/deployment-lifecycle.spec.ts |
Fixes navigation, refresh, and column-header locators. |
e2e/credential/bulk-create-from-csv-submit.spec.ts |
Updates CSV upload flow and keypair handling. |
e2e/admin-scope/admin-data-folder-create.spec.ts |
Uses semantic project-option selection. |
e2e/admin-model-card/admin-model-card-edit.spec.ts |
Updates selectors and skips backend-blocked edit tests. |
e2e/admin-model-card/admin-model-card-create.spec.ts |
Updates selectors and skips backend-blocked creation tests. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Re-running this PR's five specs against the shared test server showed the CSV bulk-create submit test failing after the heal. It is not locator drift: the modal reaches submit and the server answers "0 user(s) created. 3 user(s) failed", with each row carrying an asyncpg UndefinedColumnError — column "operation" of relation "permissions" does not exist — raised while granting the new users' RBAC rows. Single-user creation (user/user-crud.spec.ts, untouched by this PR) passes against the same server, so the missing column is on the bulk mutation's own path rather than a general user-creation outage. The failure reproduced on every attempt. Treat it the way this PR already treats the adminCreateModelCardV2 min_resource blocker: keep the corrected locators, mark the test fixme with the server error named, and drop the fixme once the manager is fixed. The coverage report moves the feature to the skipped tier. Also re-verified while triaging: the min_resource blocker is still live (temporarily unskipping the model-card create test reproduces it), so the six fixmes this PR added remain justified. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Adx8JiFzK3s1CDW93xppUj
Contributor
|
I'll test it after BA-7649 is resolved. |
…ker" This reverts commit 88bfbf3. The blocker was the shared test server, not the product. Calling adminBulkCreateUsersWithKeypairV2 directly against staging (manager 26.8.1) creates the users and persists them, with no permissions.operation error. The failure only appears on 10.82.130.172 (manager 26.8.0rc1), whose database has BA-7619's migration applied while its manager code still writes the dropped column — a mismatched deployment, not a code defect. So the test and its locators were right all along and the fixme removes coverage for nothing. Restore the test and the coverage report entry. The test will keep failing on 10.82.130.172 until that server is redeployed. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Adx8JiFzK3s1CDW93xppUj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
데일리 다이제스트 파이프라인의 e2e 자동 힐링 결과입니다 (2026-09-04 런, 전체 스위트 715건 중 92건 실패 → 트리아지 18 HEAL / 74 HUMAN).
테스트측 드리프트만 수정했습니다.
react/,packages/등 앱 소스는 건드리지 않았습니다.힐링 완료 (재실행 통과 검증)
e2e/admin-model-card/admin-model-card-create.spec.tsSelector) / Model Storage Folder(ComplexSelector)에 남아 있던.ant-select-content잔재 제거 →getByRole('combobox')및 페이지오브젝트 헬퍼로 전환. 폼아이템 라벨 vs ComplexSelector 내부 라벨 strict-mode 충돌도 해소e2e/serving/deployment-lifecycle.spec.tsgetByRole('navigation')가 사이드바+브레드크럼 2개에 매칭되던 strict-mode 위반을{ name: 'Side navigation' }스코프로 해소. 이어서 드러난 Refresh 버튼 접근성 이름(reload→Refresh, exact)과 Created At 컬럼헤더 이름(정렬 버튼 라벨) 드리프트도 함께 수정e2e/credential/bulk-create-from-csv-submit.spec.ts.ant-space-compact/"ellipsis" →getByRole('group', { name: 'Create User' })+getByRole('button', { name: 'More' }). 파일 input 로케이터 교정,.ant-message→ ToastViewport 스코프, CSV 모달이 닫히기 전에 뜨는 "Keypair for new users" 다이얼로그 처리 추가(기존KeyPairModal페이지오브젝트 재사용)e2e/admin-scope/admin-data-folder-create.spec.tspage.waitForSelector('.ant-select-dropdown')→getByRole('option', { name, exact: true })백엔드 블로커로
test.fixme처리 (6건)adminCreateModelCardV2뮤테이션이 서버측에서 실패합니다:admin-model-card-create.spec.ts— "only required fields", "all fields populated" (2건)admin-model-card-edit.spec.ts— describe 전체 4건 (공용beforeEach가 같은 뮤테이션으로 카드를 시드)로케이터 수정은 올바르므로 그대로 두고, 실패 원인이 테스트가 아님을 확인하기 위해 토스트 대기 대신
page.waitForResponse기반 응답 동기화를 넣어 서버 에러를 직접 확인한 뒤test.fixme를 걸었습니다. 매니저측 수정 후 fixme를 걷어내면 됩니다. 이 뮤테이션 버그는 오늘 admin-model-card 영역 실패 21건 중 13건의 단일 원인이기도 합니다.재검증 (2026-09-04, 이 브랜치를 그대로 재실행)
다섯 스펙을 공용 테스트 서버(
10.82.130.172:8090)에 다시 돌린 결과입니다.admin-model-card-create4건,admin-data-folder-create1건,deployment-lifecycle의 "deployments list with expected columns" 1건 모두 통과했습니다.min_resource블로커는 아직 살아 있습니다. 모델카드 create 테스트의test.fixme를 임시로 풀어 재현했으므로, 이 PR이 건 fixme 6건은 그대로 유효합니다.column "operation" of relation "permissions" does not exist로 실패해 한때test.fixme를 걸었으나, 되돌렸습니다. 스테이징(매니저 26.8.1)에 같은 뮤테이션adminBulkCreateUsersWithKeypairV2를 직접 호출하면 사용자가 정상 생성·저장됩니다. 실패는10.82.130.172(매니저 26.8.0rc1)에서만 나오고, 그 서버는 DB에 BA-7619 마이그레이션이 적용된 반면 매니저 코드가 여전히 삭제된 컬럼을 씁니다. 제품 결함이 아니라 그 서버의 배포 불일치이므로 테스트와 로케이터는 옳습니다. 해당 서버가 재배포될 때까지는 거기서만 실패합니다. (BA-7649는 Not Planned로 닫음)min_resource블로커의 사정권은 이 PR이 fixme 건 6건보다 넓습니다.admin-model-card디렉터리를 통째로 돌려보니 delete / filter / page-load / sort-refresh 스펙에서도 9건이 같은adminCreateModelCardV2에러로 시드 단계에서 죽습니다. 이 PR 범위 밖이라 손대지 않았고, 매니저가 고쳐지면 함께 살아납니다.deployment-lifecycle.spec.ts의 나머지 6건은 이 PR이 손대지 않은, 트리아지에서 HUMAN으로 분류된 기존 실패 그대로입니다 (태그 입력 placeholder 드리프트,getByRole('alert')strict-mode 위반 2건 매칭, Advanced Mode 리비전 미부착, Desired Replicas 반영 안 됨, Metric Name 콤보박스 없음, 오토스케일링 규칙 삭제 클릭 타임아웃).리포트
전체 실패 목록·트리아지 판정:
/home/ubuntu/e2e-digest-reports/report-2026-09-04.md(러너 로컬)🤖 Generated with Claude Code