fix(FR-3844): gate the preset modelDefinition selection on 26.4.4

[agatha197]

Resolves #9406 (FR-3844)

Why

The v26.9.0 release risk digest (FR-3663) flagged PresetModelConfig.name / .service, PresetModelDefinition.models and PresetModelServiceConfig.healthCheck as used without @since in DeploymentPresetDetailModal.tsx.

Those three types are the 26.9.0 (BA-7210 / FR-3481) renames of ModelDefinition / ModelConfig / ModelServiceConfig; every field name the WebUI selects exists on both generations, so 26.9.0 is not the version boundary for the query. Gating those fields at 26.9.0 would hide preset health-check data that 26.4.4 – 26.8.x managers do return.

The real gap is one level up: DeploymentRevisionPreset exists since 26.4.2, but its modelDefinition field (query and input) only since 26.4.4, and nothing on the preset surfaces gated it:

• the two preset fragments selected modelDefinition ungated, so a 26.4.2 / 26.4.3 manager rejected the whole preset query (the FR-3673 failure class);
• the preset form still rendered the Model Definition card and sent modelDefinition in the create / update input, which those managers reject. Input fields cannot carry @since, so only a supports() guard can cover that side.

What

Query gating (@since)

• DeploymentPresetDetailModalFragment (also reused by DeploymentAddRevisionModalPresetDetailQuery) and AdminDeploymentPresetSettingPageContent_preset: modelDefinition @since(version: "26.4.4"). Relay artifacts regenerated.

Render / input gating (supports())

• client.ts: new preset-model-definition feature flag, set at 26.4.4 next to model-mount-subpath.
• AdminDeploymentPresetSettingPage.tsx: the modelDefinition key is omitted from both preset mutations when unsupported (same ...(flag && { key }) pattern as subpath).
• AdminDeploymentPresetSettingPageContent.tsx: the Model Definition card is not rendered when unsupported. On those managers preset-model-config-type is also false, so the Service Configuration / Health Check / Pre-Start Actions items (nested in that card for legacy managers) disappear with it; the review step already keys off the switch, so it shows nothing extra.
• DeploymentPresetDetailModal.tsx: the service-configuration section depends on the flag explicitly instead of on the stripped field happening to be empty.
• AdminDeploymentPresetReviewSummary.tsx: the review-step Model Definition rows are gated on the same flag, so a create-mode URL restored with modelDefinition.enabled on an unsupported manager does not show data the submit omits (Copilot pass 1).

A gated ancestor covers every nested selection under the digest's rule, so the four flagged fields no longer appear.

Dev server

http://fr-3844-pr9408-version-control.sujin.10-82-0-159.sslip.io/admin/deployments?tab=deployment-presets (dev VPN, via dev-gw; login form pre-fills the shared test backend and account)

How to check:

• Open any preset's detail (eye icon) — the Service Configuration / Health Check section renders exactly as before on the shared 26.9.x backend.
• Create / Edit a preset → Step 2 (Model & Execution) still shows the Model Definition card; Review step shows its rows when the switch is on.
• The pre-26.4.4 branch (card hidden, modelDefinition omitted from the mutation) needs an older manager or a supports('preset-model-definition') override; it is not reachable on the shared backend — see FR-3845 for the E2E that will cover it.

Verification

• bash scripts/verify.sh → === ALL PASS ===
• vitest run src/components/DeploymentAddRevisionModal.test.tsx src/form-engine/formEngineAcceptance.test.tsx → 34 passed
• node scripts/release-risk-report.mjs --from v26.8.1 --to <ref> --json, version-gating gaps mentioning the preset types:
  • origin/main: 4 (PresetModelConfig.name, PresetModelConfig.service, PresetModelDefinition.models, PresetModelServiceConfig.healthCheck, all in DeploymentPresetDetailModal.tsx)
  • this branch: 0

Not covered here: description and imageId on the same preset input are also "Added in 26.4.4" and remain unguarded, as before this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DH9zan75dZ8t5X5TjHdsP3

[github-actions]

Coverage Report for react-coverage (./react)

Status	Category	Percentage	Covered / Total
🔵	Lines	15.54%	5656 / 36384
🔵	Statements	13.03%	6890 / 52853
🔵	Functions	13.59%	881 / 6481
🔵	Branches	9.41%	4761 / 50555

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
react/src/components/AdminDeploymentPresetReviewSummary.tsx	0%	0%	0%	0%	42-564
react/src/components/AdminDeploymentPresetSettingPageContent.tsx	0%	0%	0%	0%	141-740
react/src/components/DeploymentPresetDetailModal.tsx	2.38%	0%	0%	5%	40-219
react/src/pages/AdminDeploymentPresetSettingPage.tsx	0%	0%	0%	0%	40-593

Generated in workflow #514 for commit a9ec35e by the Vitest Coverage Report Action

[Copilot]

🟡 Changes recommended

Unsupported model-definition data can still appear during review after URL state restoration.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds v26.4.4 capability gating for deployment preset model definitions.

Changes:

• Adds the preset-model-definition capability.
• Gates related queries, mutation inputs, and UI.
• Regenerates affected Relay artifacts.

File summaries

File	Review
react/src/pages/AdminDeploymentPresetSettingPage.tsx	Omits unsupported mutation input. Nit: Missing pre-26.4.4 E2E coverage.
react/src/components/DeploymentPresetDetailModal.tsx	Gates model-definition details.
react/src/components/AdminDeploymentPresetSettingPageContent.tsx	Gates the form card. Moderate: URL-restored state can still display unsupported review data.
react/src/__generated__/VFolderDeployModalQuery.graphql.ts	Regenerates Relay query.
react/src/__generated__/ModelCardDrawerQuery.graphql.ts	Regenerates Relay query.
react/src/__generated__/DeploymentPresetDetailModalFragment.graphql.ts	Regenerates Relay fragment.
react/src/__generated__/DeploymentAddRevisionModalPresetDetailQuery.graphql.ts	Regenerates Relay query.
react/src/__generated__/DeploymentAddRevisionModalCardDetailQuery.graphql.ts	Regenerates Relay query.
react/src/__generated__/AdminDeploymentPresetSettingPageUpdateMutation.graphql.ts	Regenerates Relay mutation.
react/src/__generated__/AdminDeploymentPresetSettingPagePresetQuery.graphql.ts	Regenerates Relay query.
react/src/__generated__/AdminDeploymentPresetSettingPageCreateMutation.graphql.ts	Regenerates Relay mutation.
react/src/__generated__/AdminDeploymentPresetSettingPageContent_preset.graphql.ts	Regenerates Relay fragment.
packages/backend.ai-client/src/client.ts	Adds the v26.4.4 capability flag.

Review details

Files not reviewed (9)

• react/src/generated/AdminDeploymentPresetSettingPageContent_preset.graphql.ts: Generated file
• react/src/generated/AdminDeploymentPresetSettingPageCreateMutation.graphql.ts: Generated file
• react/src/generated/AdminDeploymentPresetSettingPagePresetQuery.graphql.ts: Generated file
• react/src/generated/AdminDeploymentPresetSettingPageUpdateMutation.graphql.ts: Generated file
• react/src/generated/DeploymentAddRevisionModalCardDetailQuery.graphql.ts: Generated file
• react/src/generated/DeploymentAddRevisionModalPresetDetailQuery.graphql.ts: Generated file
• react/src/generated/DeploymentPresetDetailModalFragment.graphql.ts: Generated file
• react/src/generated/ModelCardDrawerQuery.graphql.ts: Generated file
• react/src/generated/VFolderDeployModalQuery.graphql.ts: Generated file

Suppressed comments (1)

react/src/pages/AdminDeploymentPresetSettingPage.tsx:223

• The new compatibility branch is not covered by the existing preset E2E scenarios: both flag installers leave preset-model-definition to the test manager's normal value, so it remains true and neither the card-hidden path nor omission from create/update inputs is asserted. Add a pre-26.4.4 capability override and verify that the card is absent and the captured mutation input has no modelDefinition key; this guards the exact regression this change addresses.

  // `modelDefinition` exists on the preset input since 26.4.4; older managers
  // reject the key, so it is left out of the mutation entirely.
  const supportsModelDefinition = baiClient.supports('preset-model-definition');

• Files reviewed: 4/13 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The only unresolved finding is a non-blocking test-coverage nit.

Review details

Files not reviewed (9)

• react/src/generated/AdminDeploymentPresetSettingPageContent_preset.graphql.ts: Generated file
• react/src/generated/AdminDeploymentPresetSettingPageCreateMutation.graphql.ts: Generated file
• react/src/generated/AdminDeploymentPresetSettingPagePresetQuery.graphql.ts: Generated file
• react/src/generated/AdminDeploymentPresetSettingPageUpdateMutation.graphql.ts: Generated file
• react/src/generated/DeploymentAddRevisionModalCardDetailQuery.graphql.ts: Generated file
• react/src/generated/DeploymentAddRevisionModalPresetDetailQuery.graphql.ts: Generated file
• react/src/generated/DeploymentPresetDetailModalFragment.graphql.ts: Generated file
• react/src/generated/ModelCardDrawerQuery.graphql.ts: Generated file
• react/src/generated/VFolderDeployModalQuery.graphql.ts: Generated file

Suppressed comments (1)

react/src/pages/AdminDeploymentPresetSettingPage.tsx:223

• The new pre-26.4.4 compatibility path is not exercised by the listed Vitest tests, although e2e/serving/admin-preset-service-config.spec.ts already tests this page's capability-controlled rendering and mutation payloads. Add an unsupported-manager scenario that forces preset-model-definition off and verifies the card/review data stay hidden and modelDefinition is absent from the submitted input; otherwise the core FR-3844 behavior can regress while verification still passes.

  // `modelDefinition` exists on the preset input since 26.4.4; older managers
  // reject the key, so it is left out of the mutation entirely.
  const supportsModelDefinition = baiClient.supports('preset-model-definition');

• Files reviewed: 5/14 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[agatha197]

Dev server on box sujin: http://fr-3844-pr9408-version-control.sujin.10-82-0-159.sslip.io