🐛 inject min boundaries for +k8s:required on strings, maps, and slices

[lalitc375]

What does this do, and why do we need it?

This PR updates the CRD generation logic for the +k8s:required marker to automatically apply minimum boundaries to strings, arrays, and objects.

Specifically, when a field is marked as required, this change will now automatically inject:

• minLength=1 for string types.
• minItems=1 for array (slice) types.
• minProperties=1 for object (map) types.

This aligns with the implementation of +k8s:required of validation-gen of kubernetes. https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/api/validate/required.go

There is no clean way to model required int in CRD as of now. We will handle it separately.

There are no prod usage outside of k/k for +k8s:required. It is fine to change now then later. CRs are ratcheted, It is safe to change it. https://grep.app/search?q=%2Bk8s%3Arequired+

[kubernetes-prow]

Hi @lalitc375. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lalitc375]

/assign @JoelSpeed

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lalitc375
Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/ok-to-test

CC @sbueringer @alvaroaleman

This aligns the markers to their upstream behaviour, but is technically a breaking change for our users who might have adopted these already (though they are pretty new). I'm in favour of merging this, so please LMK if you have concerns