🐛 (for all generators): fix being silently ignored when placed directly above var/const/func declarations without a blank line. Both with and without blank line styles now work

[camilamacedo86]

Package-level markers like +kubebuilder:rbac, +kubebuilder:webhook, +groupName, etc. were silently ignored when placed directly above

Both styles now work (backward compatible):

• With blank line (already worked)
• Without blank line (now fixed)

Closes #551

Assisted-by: Claude

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

This implies to me that at some point there was a deliberate choice to not support what this bug fix is now supporting. What kind of impact might an end user expect from this change?

[camilamacedo86]

Good catch. That assertion verifies a separate behavior (removed by mistake). I've added it back to show the two are unrelated.

[JoelSpeed]

This feels like a relatively risky change, since it has the potential to cause huge diffs in the generation for folks who haven't noticed that their markers aren't being observed.

What about a warning when the markers are being ignored instead of suddenly observing them?

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Hi @JoelSpeed,

I'm not sure I follow the concern. If someone explicitly adds a marker, I'd expect it to take effect. Silently ignoring it feels more surprising.

POV, the current behavior is the bug. This PR fixes that by making the marker behave as documented, rather than introducing a new behavior. If the concern is unexpected diffs, those diffs would only happen because users had already added the marker but weren't getting the expected result. So, why someone would add the marker if does not want the behaviour of the mark at all?

Also, this is limited to package-level markers (such as RBAC and webhook markers). Type and field markers already work without requiring a blank line.

For example, on main today, both of these work without a blank line:

// +kubebuilder:default={}
DefaultedEmptyMap map[string]string `json:"defaultedEmptyMap"`

// +kubebuilder:validation:Required
ExplicitlyRequiredKubebuilder string `json:"...,omitempty"`

The inconsistency is that package-level markers placed the same way are silently ignored. To me, that's confusing. This PR just makes package-level markers behave consistently with the rest of the marker system.

This also matches #436, where this behavior was reported as unexpected rather than intentional.