Skip to content

fix: repair terminal rendering - #435

Merged
lixd merged 1 commit into
kubeclipper:masterfrom
lixd:fix/terminal-rendering
Sep 8, 2026
Merged

lixd merged 1 commit into
kubeclipper:masterfrom
lixd:fix/terminal-rendering

Conversation

@lixd

@lixd lixd commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove width constraints that compress the xterm.js canvas
  • keep the window resize handler stable and cancel pending debounce on unmount

Validation

  • eslint src/components/Terminal/terminal.jsx --quiet
  • CI=1 yarn test:unit (8 suites, 50 tests)
  • yarn build true
  • deployed and verified on sh-dev-2

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.24%. Comparing base (c8ec5fe) to head (6d5b0be).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   47.30%   45.24%   -2.07%     
==========================================
  Files           7        8       +1     
  Lines         613      767     +154     
  Branches      176      224      +48     
==========================================
+ Hits          290      347      +57     
- Misses        250      333      +83     
- Partials       73       87      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lixd
lixd merged commit 4ff24ec into kubeclipper:master Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant